Skip to content

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 17, 2024

This is the minimum upgrade necessary to remove dependency on deprecated web3-provider-engine.

Related

Blocked by

Copy link

socket-security bot commented Apr 17, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/@metamask/eth-json-rpc-provider@1.0.1
Network access npm/@metamask/eth-json-rpc-middleware@11.0.2
New author npm/nonce-tracker@1.2.0
Network access npm/eth-json-rpc-middleware@8.1.0
New author npm/@metamask/eth-sig-util@6.0.2
New author npm/@metamask/safe-event-emitter@3.1.1

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@metamask/eth-json-rpc-provider@1.0.1
  • @SocketSecurity ignore npm/@metamask/eth-json-rpc-middleware@11.0.2
  • @SocketSecurity ignore npm/nonce-tracker@1.2.0
  • @SocketSecurity ignore npm/eth-json-rpc-middleware@8.1.0
  • @SocketSecurity ignore npm/@metamask/eth-sig-util@6.0.2
  • @SocketSecurity ignore npm/@metamask/safe-event-emitter@3.1.1

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Apr 17, 2024
@legobeat legobeat force-pushed the deps-gas-fee-controller-6 branch from 14cc90a to 498bb7b Compare April 17, 2024 10:19
@legobeat legobeat force-pushed the deps-gas-fee-controller-6 branch from 498bb7b to 564713b Compare May 5, 2024 12:53
@legobeat legobeat closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant