feat: v10 rc #277

nikoferro · 2024-08-14T09:06:01Z

No description provided.

socket-security · 2024-08-14T09:06:23Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/code-frame@7.24.7	environment	`0`	24.1 kB	nicolo-ribaudo
npm/@babel/compat-data@7.25.4	None	`0`	101 kB	existentialism, hzoo, jlhwung, ...1 more
npm/@babel/core@7.25.2	environment, filesystem, unsafe	`0`	788 kB	nicolo-ribaudo
npm/@babel/generator@7.25.5	None	`0`	489 kB	nicolo-ribaudo
npm/@babel/helper-compilation-targets@7.25.2	None	`0`	52.3 kB	nicolo-ribaudo
npm/@babel/helper-module-imports@7.24.7	None	`0`	63.7 kB	nicolo-ribaudo
npm/@babel/helper-module-transforms@7.25.2	None	`0`	160 kB	nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.24.8	None	`0`	114 kB	nicolo-ribaudo
npm/@babel/helper-simple-access@7.24.7	None	`0`	14.1 kB	nicolo-ribaudo
npm/@babel/helper-string-parser@7.24.8	None	`0`	31.8 kB	nicolo-ribaudo
npm/@babel/helper-validator-identifier@7.24.7	None	`0`	49.3 kB	nicolo-ribaudo
npm/@babel/helper-validator-option@7.24.8	None	`0`	11.8 kB	nicolo-ribaudo
npm/@babel/helpers@7.25.0	None	`0`	876 kB	nicolo-ribaudo
npm/@babel/highlight@7.24.7	environment	`0`	20.3 kB	nicolo-ribaudo
npm/@babel/parser@7.25.4	None	`0`	1.89 MB	nicolo-ribaudo
npm/@babel/plugin-syntax-class-static-block@7.14.5	None	`0`	2.74 kB	nicolo-ribaudo
npm/@babel/plugin-syntax-import-attributes@7.24.7	None	`0`	71.1 kB	nicolo-ribaudo
npm/@babel/plugin-syntax-jsx@7.24.7	None	`0`	70 kB	nicolo-ribaudo
npm/@babel/plugin-syntax-private-property-in-object@7.14.5	None	`0`	2.82 kB	nicolo-ribaudo
npm/@babel/plugin-syntax-typescript@7.25.4	None	`0`	69.7 kB	existentialism, hzoo, jlhwung, ...1 more
npm/@babel/runtime@7.25.4	None	`0`	248 kB	nicolo-ribaudo
npm/@babel/template@7.25.0	None	`0`	70.4 kB	nicolo-ribaudo
npm/@babel/traverse@7.25.4	None	`0`	728 kB	nicolo-ribaudo
npm/@babel/types@7.25.4	environment	`0`	2.48 MB	nicolo-ribaudo
npm/@eslint-community/regexpp@4.11.0	None	`0`	446 kB	eslint-community-bot
npm/@ethersproject/contracts@5.7.0	None	`0`	250 kB	ricmoo
npm/@jridgewell/sourcemap-codec@1.5.0	None	`0`	113 kB	jridgewell
npm/@lavamoat/aa@4.3.0	None	`0`	20.1 kB	lmbot
npm/@lavamoat/allow-scripts@3.2.0	environment	`0`	48.4 kB	naugtur
npm/@metamask/abi-utils@2.0.4	None	`0`	202 kB	metamaskbot
npm/@metamask/base-controller@5.0.2	None	`0`	289 kB	metamaskbot
npm/@metamask/controller-utils@10.0.0	network	`0`	223 kB	metamaskbot
npm/@metamask/eth-block-tracker@9.0.3	None	`0`	64.5 kB	lgbot
npm/@metamask/eth-json-rpc-middleware@12.1.2	network	`0`	165 kB	metamaskbot
npm/@metamask/eth-json-rpc-provider@3.0.2	None	`0`	75.8 kB	metamaskbot
npm/@metamask/eth-sig-util@7.0.3	None	`0`	133 kB	metamaskbot
npm/@metamask/gas-fee-controller@15.1.2	None	`0`	223 kB	metamaskbot
npm/@metamask/json-rpc-engine@8.0.2	None	`0`	189 kB	metamaskbot
npm/@metamask/polling-controller@6.0.2	None	`0`	123 kB	metamaskbot
npm/@metamask/rpc-errors@6.3.1	None	`0`	133 kB	metamaskbot
npm/@metamask/superstruct@3.1.0	None	`0`	437 kB	metamaskbot
npm/@metamask/utils@8.5.0	None	`0`	692 kB	metamaskbot
npm/@noble/curves@1.4.2	None	`0`	1.5 MB	paulmillr
npm/@npmcli/fs@3.1.1	filesystem	`0`	26.5 kB	lukekarrys
npm/@npmcli/git@5.0.8	environment, filesystem	`0`	23 kB	npm-cli-ops
npm/@npmcli/package-json@5.2.0	filesystem	`0`	39.5 kB	npm-cli-ops
npm/@npmcli/promise-spawn@7.0.2	environment, shell	`0`	12.2 kB	npm-cli-ops
npm/@npmcli/run-script@8.1.0	environment	`0`	18.3 kB	npm-cli-ops
npm/@scure/base@1.1.7	None	`0`	122 kB	paulmillr
npm/@scure/bip32@1.4.0	None	`0`	58.7 kB	paulmillr
npm/@scure/bip39@1.3.0	None	`0`	374 kB	paulmillr
npm/@spruceid/siwe-parser@2.1.0	None	`0`	36.3 kB	sbihel
npm/@types/babel__traverse@7.20.6	None	`0`	84.1 kB	types
npm/@types/node@20.16.1	None	`0`	2.1 MB	types
npm/acorn-walk@8.3.3	None	`0`	52.6 kB	marijn
npm/acorn@8.12.1	None	`0`	538 kB	marijn
npm/apg-js@4.4.0	filesystem	`0`	1.46 MB	ldthomas
npm/async-mutex@0.5.0	None	`0`	63 kB	dirtyhairy
npm/async@3.2.6	None	`0`	808 kB	aearly
npm/babel-preset-current-node-syntax@1.1.0	eval	`0`	7.13 kB	nicolo-ribaudo
npm/bin-links@4.0.4	filesystem	`0`	20.7 kB	npm-cli-ops
npm/browserslist@4.23.3	environment, filesystem	`0`	63 kB	ai
npm/cacache@18.0.4	filesystem	`0`	63.7 kB	npm-cli-ops
npm/caniuse-lite@1.0.30001653	None	`0`	2.1 MB	ai, beneb, caniuse-lite
npm/cjs-module-lexer@1.4.0	None	`0`	146 kB	guybedford, nodejs-foundation
npm/cmd-shim@6.0.3	filesystem	`0`	12.2 kB	npm-cli-ops
npm/debug@4.3.6	environment	`0`	42.4 kB	qix
npm/ejs@3.1.10	eval, filesystem	`0`	143 kB	mde
npm/electron-to-chromium@1.5.13	None	`0`	146 kB	kilianvalkhof
npm/eslint-module-utils@2.8.2	None	`0`	49.3 kB	ljharb
npm/eslint-plugin-promise@6.6.0	None	`0`	72.5 kB	eslint-community-bot
npm/esquery@1.6.0	None	`0`	1.04 MB	michaelficarra
npm/ethereum-cryptography@2.2.1	None	`0`	83.7 kB	paulmillr
npm/filelist@1.0.4	filesystem	`0`	18.6 kB	mde
npm/foreground-child@3.3.0	shell	`0`	69 kB	isaacs
npm/glob@10.4.5	None	`0`	475 kB	isaacs
npm/globalthis@1.0.4	None	`0`	23.7 kB	ljharb
npm/hosted-git-info@7.0.2	None	`0`	26.6 kB	npm-cli-ops
npm/https-proxy-agent@7.0.5	network	`0`	34.9 kB	tootallnate
npm/ignore@5.3.2	None	`0`	53.6 kB	kael
npm/import-local@3.2.0	None	`0`	4.73 kB	sindresorhus
npm/ini@4.1.3	None	`0`	12.1 kB	npm-cli-ops
npm/is-core-module@2.15.1	None	`0`	32.7 kB	ljharb
npm/istanbul-lib-instrument@6.0.3	None	`0`	72 kB	oss-bot
npm/jackspeak@3.4.3	environment	`0`	297 kB	isaacs
npm/jake@10.9.2	environment, filesystem, shell	`0`	175 kB	mde
npm/js-sha3@0.8.0	None	`0`	52.9 kB	emn178
npm/json-parse-even-better-errors@3.0.2	None	`0`	9.94 kB	npm-cli-ops
npm/lru-cache@10.4.3	None	`0`	804 kB	isaacs
npm/make-fetch-happen@13.0.1	network	`0`	52.8 kB	npm-cli-ops
npm/micromatch@4.0.8	None	`0`	56.6 kB	doowb
npm/minimatch@9.0.5	environment	`0`	435 kB	isaacs
npm/minipass-fetch@3.0.5	environment, network	`0`	46.8 kB	npm-cli-ops
npm/node-gyp@10.2.0	environment, shell	`0`	1.85 MB	nodejs-foundation
npm/node-releases@2.0.18	None	`0`	35.7 kB	chicoxyzzy
npm/nopt@7.2.1	None	`0`	26.2 kB	npm-cli-ops
npm/normalize-package-data@6.0.2	None	`0`	28.2 kB	npm-cli-ops
npm/npm-package-arg@11.0.3	None	`0`	19.2 kB	npm-cli-ops
npm/npm-pick-manifest@9.1.0	None	`0`	16.5 kB	npm-cli-ops
npm/nwsapi@2.2.12	None	`0`	80.6 kB	diego
npm/object-inspect@1.13.2	None	`0`	99.1 kB	ljharb
npm/optionator@0.9.4	None	`0`	50.2 kB	gkz
npm/package-json-from-dist@1.0.0	None	`0`	33.9 kB	isaacs
npm/path-scurry@1.11.1	filesystem	`0`	535 kB	isaacs
npm/picocolors@1.0.1	environment	`0`	5.15 kB	alexeyraspopov
npm/safe-stable-stringify@2.5.0	None	`0`	30.7 kB	bridgear
npm/semver@7.6.3	None	`0`	95.8 kB	npm-cli-ops
npm/socks-proxy-agent@8.0.4	network	`0`	24.8 kB	tootallnate
npm/spdx-license-ids@3.0.20	None	`0`	13 kB	kemitchell, shinnn
npm/ssri@10.0.6	None	`0`	38.7 kB	npm-cli-ops
npm/tough-cookie@4.1.4	None	`0`	112 kB	ccasey
npm/ts-jest@29.2.5	None	`0`	328 kB	anhpnnd, kul, tsjest
npm/tslib@2.7.0	None	`0`	86.2 kB	typescript-bot
npm/typescript@5.5.4	None	`0`	21.9 MB	typescript-bot
npm/undici-types@6.19.8	None	`0`	84.2 kB	ethan_arrowood, matteo.collina
npm/update-browserslist-db@1.1.0	environment, filesystem, shell	`0`	14.8 kB	ai
npm/v8-to-istanbul@9.3.0	filesystem, unsafe	`0`	47.6 kB	oss-bot
npm/valid-url@1.0.9	None	`0`	17.2 kB	odysseas
npm/validate-npm-package-name@5.0.1	unsafe	`0`	7.77 kB	npm-cli-ops
npm/word-wrap@1.2.5	None	`0`	11.8 kB	jonschlinkert
npm/ws@7.5.10	network	`0`	122 kB	lpinca

View full report↗︎

socket-security · 2024-08-14T09:06:26Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@lavamoat/aa@4.3.0, npm/@spruceid/siwe-parser@2.1.0, npm/jake@10.9.2, npm/node-gyp@10.2.0, npm/validate-npm-package-name@5.0.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

…280) * chore: updating dependencies to match mobile current versions * feat: basecontrollerv2 refactor * fix: linter fix * fix: test fix * chore: exposing types of actions and events * fix: removing provider from state since its not serializable * fix: fix for resetting state while keeping the current chain and last fetched config * chore: export controller types * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/constants.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/swapsUtil.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * chore: pr feedback changes * chore: make explicit which properties are already anonymous * chore: default value for state as an optional parameter * fix: remove any types and improve util types * fix: removes type cast that is no longer needed Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> --------- Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> Co-authored-by: Marta Poling <marta.hourigan.johnson@gmail.com>

* chore: updating dependencies to match mobile current versions * feat: basecontrollerv2 refactor * fix: linter fix * fix: test fix * chore: exposing types of actions and events * fix: removing provider from state since its not serializable * fix: fix for resetting state while keeping the current chain and last fetched config * chore: export controller types * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/constants.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/swapsUtil.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * chore: pr feedback changes * chore: make explicit which properties are already anonymous * chore: default value for state as an optional parameter * chore: remove web3 package * chore: add @ethersproject/contracts * chore: add @ethersproject/providers * chore: remove web3 and use ethers contracts instead * fix: broken tests --------- Co-authored-by: nikoferro <nicolaspatricioferro@gmail.com> Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

…y vulnerability status

martahj · 2024-08-27T15:41:26Z

@SocketSecurity ignore npm/@lavamoat/aa@4.3.0

Lavamoat is trustworthy; new author is not a concern

martahj · 2024-08-27T15:44:49Z

@SocketSecurity ignore npm/@spruceid/siwe-parser@2.1.0

This comes from @metamask/controller-utils and will be evaluated there. Also, new author is a low concern issue.

martahj · 2024-08-27T15:46:07Z

@SocketSecurity ignore npm/node-gyp@10.2.0

New author is Node foundation

martahj · 2024-08-27T15:54:34Z

@SocketSecurity ignore npm/jake@10.9.2

jake comes in from ts-jest > els > jake. ts-jest is only a dev dependency (used for testing) so shell access should be ok. It is also a major package that is generally trusted by the community.

martahj · 2024-08-27T16:01:52Z

@SocketSecurity ignore npm/validate-npm-package-name@5.0.1

This is ultimately coming in from Lavamoat and the new author looks established and legitimate.

infiniteflower · 2024-08-28T18:03:35Z

Tested on Android emulator and iOS simulator, seems to be working fine

Tested on Android physical device, startup performance looks good

infiniteflower · 2024-08-28T18:25:16Z

Davide is in the middle of testing this as well against this Mobile PR MetaMask/metamask-mobile#10787

EDIT: he says it's working fine

This reverts commit f120258.

This reverts commit 27790db.

* Revert "Revert "feat: v10 rc (#277)" (#308)" This reverts commit 27790db. * fix: lint issue

nikoferro and others added 4 commits August 27, 2024 09:41

chore: updating dependencies to match mobile current versions (#271)

53a9c1f

chore: update yarn lock after fixing merge conflicts

c99f87e

martahj force-pushed the rc-v10 branch from d1e72ac to c99f87e Compare August 27, 2024 14:43

martahj added 2 commits August 27, 2024 09:53

chore: update syntax for linter

20b1557

chore: pin version of ethersproject dependency ws due to high securit…

9f7725c

…y vulnerability status

martahj marked this pull request as ready for review August 27, 2024 16:02

martahj requested a review from a team August 27, 2024 16:02

infiniteflower approved these changes Aug 28, 2024

View reviewed changes

infiniteflower merged commit f120258 into main Aug 28, 2024
2 checks passed

infiniteflower deleted the rc-v10 branch August 28, 2024 18:43

infiniteflower added a commit that referenced this pull request Aug 30, 2024

Revert "feat: v10 rc (#277)"

ac859f1

This reverts commit f120258.

infiniteflower added a commit that referenced this pull request Aug 30, 2024

Revert "feat: v10 rc (#277)" (#308)

27790db

This reverts commit f120258.

infiniteflower mentioned this pull request Sep 3, 2024

Rc v10 redo #313

Closed

infiniteflower added a commit that referenced this pull request Sep 4, 2024

Revert "Revert "feat: v10 rc (#277)" (#308)"

000c6ed

This reverts commit 27790db.

infiniteflower mentioned this pull request Sep 4, 2024

Revert "Revert "feat: v10 rc (#277)" (#308)" #314

Merged

infiniteflower added a commit that referenced this pull request Sep 4, 2024

Revert "Revert "feat: v10 rc (#277)" (#308)" (#314)

ba9d2a2

* Revert "Revert "feat: v10 rc (#277)" (#308)" This reverts commit 27790db. * fix: lint issue

nikoferro mentioned this pull request Sep 27, 2024

chore: @metamask/swaps-controller v9 -> v10 MetaMask/metamask-mobile#10743

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: v10 rc #277

feat: v10 rc #277

Uh oh!

nikoferro commented Aug 14, 2024

Uh oh!

socket-security bot commented Aug 14, 2024 •

edited

Loading

Uh oh!

socket-security bot commented Aug 14, 2024 •

edited

Loading

Uh oh!

martahj commented Aug 27, 2024 •

edited

Loading

Uh oh!

martahj commented Aug 27, 2024 •

edited

Loading

Uh oh!

martahj commented Aug 27, 2024 •

edited

Loading

Uh oh!

martahj commented Aug 27, 2024 •

edited

Loading

Uh oh!

martahj commented Aug 27, 2024

Uh oh!

infiniteflower commented Aug 28, 2024 •

edited

Loading

Uh oh!

infiniteflower commented Aug 28, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: v10 rc #277

feat: v10 rc #277

Uh oh!

Conversation

nikoferro commented Aug 14, 2024

Uh oh!

socket-security bot commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next steps

Uh oh!

martahj commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

martahj commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

martahj commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

martahj commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

martahj commented Aug 27, 2024

Uh oh!

infiniteflower commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infiniteflower commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

socket-security bot commented Aug 14, 2024 •

edited

Loading

socket-security bot commented Aug 14, 2024 •

edited

Loading

martahj commented Aug 27, 2024 •

edited

Loading

martahj commented Aug 27, 2024 •

edited

Loading

martahj commented Aug 27, 2024 •

edited

Loading

martahj commented Aug 27, 2024 •

edited

Loading

infiniteflower commented Aug 28, 2024 •

edited

Loading

infiniteflower commented Aug 28, 2024 •

edited

Loading