Rc v10 redo #313
Closed
Rc v10 redo #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…280) * chore: updating dependencies to match mobile current versions * feat: basecontrollerv2 refactor * fix: linter fix * fix: test fix * chore: exposing types of actions and events * fix: removing provider from state since its not serializable * fix: fix for resetting state while keeping the current chain and last fetched config * chore: export controller types * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/constants.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/swapsUtil.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * chore: pr feedback changes * chore: make explicit which properties are already anonymous * chore: default value for state as an optional parameter * fix: remove any types and improve util types * fix: removes type cast that is no longer needed Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> --------- Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> Co-authored-by: Marta Poling <marta.hourigan.johnson@gmail.com>
* chore: updating dependencies to match mobile current versions * feat: basecontrollerv2 refactor * fix: linter fix * fix: test fix * chore: exposing types of actions and events * fix: removing provider from state since its not serializable * fix: fix for resetting state while keeping the current chain and last fetched config * chore: export controller types * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/constants.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/swapsUtil.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * chore: pr feedback changes * chore: make explicit which properties are already anonymous * chore: default value for state as an optional parameter * chore: remove web3 package * chore: add @ethersproject/contracts * chore: add @ethersproject/providers * chore: remove web3 and use ethers contracts instead * fix: broken tests --------- Co-authored-by: nikoferro <nicolaspatricioferro@gmail.com> Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
…y vulnerability status
|
Closing in favor of #314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reapplies the work from #277