Skip to content

[Wrong] Remove field settings form the dca.#14

Closed
baumannsven wants to merge 2 commits intoMetaModels:masterfrom
ContaoBlackForest-archive:hotfix/field_settings
Closed

[Wrong] Remove field settings form the dca.#14
baumannsven wants to merge 2 commits intoMetaModels:masterfrom
ContaoBlackForest-archive:hotfix/field_settings

Conversation

@baumannsven
Copy link
Copy Markdown
Member

The field settings are defined by attribute_file.

Copy link
Copy Markdown
Contributor

@zonky2 zonky2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTM

@discordier
Copy link
Copy Markdown
Member

Not really, now we have to add a requirement on attribute_file as otherwise the fields will not get defined at all!

@discordier discordier self-requested a review May 30, 2017 17:44
Copy link
Copy Markdown
Member

@discordier discordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "metamodels/attribute_file": "^2.0.0" to requirements of composer.json

@baumannsven baumannsven changed the base branch from develop to master May 30, 2017 18:39
@zonky2
Copy link
Copy Markdown
Contributor

zonky2 commented May 30, 2017

@discordier nu RTM ?

@zonky2
Copy link
Copy Markdown
Contributor

zonky2 commented Oct 13, 2017

@discordier pls check this PR again...

@discordier discordier modified the milestones: 2.0.0, 2.0.3 Dec 5, 2017
@zonky2
Copy link
Copy Markdown
Contributor

zonky2 commented Mar 6, 2018

@discordier see #14 (comment)

@zonky2 zonky2 changed the title Remove field settings form the dca. [Wrong] Remove field settings form the dca. Mar 6, 2018
@zonky2
Copy link
Copy Markdown
Contributor

zonky2 commented Mar 6, 2018

wie in MM-call beschlossen, soll es (möglichst) keine Abhängigkeiten zwischen den Attributen geben...

@zonky2 zonky2 closed this Mar 6, 2018
@discordier discordier removed this from the 2.0.3 milestone Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants