Skip to content

Add identifier for internal attribute for exclude by some methods#1107

Merged
stefanheimes merged 1 commit intoMetaModels:hotfix/2.0.0-alpha16from
ContaoBlackForest-archive:feature/virtual_attribute
May 29, 2017
Merged

Add identifier for internal attribute for exclude by some methods#1107
stefanheimes merged 1 commit intoMetaModels:hotfix/2.0.0-alpha16from
ContaoBlackForest-archive:feature/virtual_attribute

Conversation

@baumannsven
Copy link
Copy Markdown
Member

@baumannsven baumannsven commented Apr 11, 2017

This feature is useful for better work with virtual attribute.
Virtual attribute has problem if we get parse values from item.
You can see this by attribute_file by the virtual FileOrder.

@zonky2 zonky2 added the enhancement This issue is about an enhancement (aka new feature) label Apr 19, 2017
@zonky2 zonky2 added this to the 2.0.0 milestone Apr 19, 2017
@zonky2 zonky2 closed this Apr 19, 2017
@discordier discordier reopened this Apr 19, 2017
@richardhj
Copy link
Copy Markdown
Member

Can we find another name than IVirtual? IMHO it is hard to catch, what a "virtual attribute" is.
Or at least adjust the description

Interface for "virtual" MetaModel attributes.
This interface is helper for check if the attribute is virtual.

@discordier
Copy link
Copy Markdown
Member

I am with @richardhj on this one. We might want to change the name to something else IInternal would IMO re ensemble unrenderable and unmodifyable attributes more closely.
In the end, we should rethink what types of attributes we really have in addition to the current ones.

Finally I do not understand why "virtual" attributes should get excluded from rendering.

@baumannsven
Copy link
Copy Markdown
Member Author

The IVirtual name comes from logic exception who throw by attribute_file.
What ist the problem for the name of this interface? Can you tell me why?

https://github.com/MetaModels/attribute_file/blob/hotfix/order-field/src/MetaModels/Attribute/File/FileOrder.php#L101

@zonky2 zonky2 added the Up for discussion This ticket will be up for discussion in one of our next calls label Apr 25, 2017
@discordier
Copy link
Copy Markdown
Member

The problem is only with the naming. In the end, almost all attributes are "virtual" because they are not part of the "entity" but only added.
MetaModels is sort of an EAV system where all attributes are "virtual", having some of them now named "virtual" does not help and therefore we are searching for a better name.

@baumannsven
Copy link
Copy Markdown
Member Author

baumannsven commented May 18, 2017

Now i understood the naming for this interface. I rename this interface.

@zonky2 zonky2 removed the Up for discussion This ticket will be up for discussion in one of our next calls label May 18, 2017
@zonky2
Copy link
Copy Markdown
Contributor

zonky2 commented May 22, 2017

IInternal

@discordier discordier changed the base branch from hotfix/alpha-15 to hotfix/alpha-16 May 22, 2017 22:06
@discordier discordier reopened this May 22, 2017
@stefanheimes stefanheimes changed the base branch from hotfix/alpha-16 to hotfix/2.0.0-alpha16 May 22, 2017 22:46
@stefanheimes stefanheimes reopened this May 22, 2017
@baumannsven baumannsven changed the title Add identifier for virtual attribute for exclude by some methods Add identifier for internal attribute for exclude by some methods May 24, 2017
@baumannsven
Copy link
Copy Markdown
Member Author

baumannsven commented May 24, 2017

I have switch the interface name from IVirtual to IInternal,

@zonky2 zonky2 self-requested a review May 29, 2017 06:00
@stefanheimes stefanheimes merged commit a505996 into MetaModels:hotfix/2.0.0-alpha16 May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This issue is about an enhancement (aka new feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants