Skip to content

[RTM] hotfix issue #1203 add all_langs option#1204

Merged
stefanheimes merged 1 commit intoMetaModels:hotfix/2.0.0-alpha18from
zonky2:hotfix_issue_#1203_add_all_langs_option
Mar 8, 2018
Merged

[RTM] hotfix issue #1203 add all_langs option#1204
stefanheimes merged 1 commit intoMetaModels:hotfix/2.0.0-alpha18from
zonky2:hotfix_issue_#1203_add_all_langs_option

Conversation

@zonky2
Copy link
Copy Markdown
Contributor

@zonky2 zonky2 commented Oct 19, 2017

hotfix issue #1203 add all_langs option
see preparePalettes
6ae958e

@zonky2 zonky2 added the bug A bug! A bug! Fast, squish it! label Oct 19, 2017
@zonky2 zonky2 added this to the 2.0.0 milestone Oct 19, 2017
@zonky2 zonky2 force-pushed the hotfix_issue_#1203_add_all_langs_option branch 2 times, most recently from b6ccd60 to 0456957 Compare October 19, 2017 15:05
@discordier discordier changed the base branch from master to hotfix/2.0.0-alpha18 March 6, 2018 12:41
@zonky2 zonky2 force-pushed the hotfix_issue_#1203_add_all_langs_option branch 2 times, most recently from 5b31bd3 to 0140e18 Compare March 6, 2018 14:54
@zonky2
Copy link
Copy Markdown
Contributor Author

zonky2 commented Mar 6, 2018

at this time work for filter type simple lookup...

for transladed text and filter text we should add at tl_metamodel_filtersetting (translated text)

$GLOBALS['TL_DCA']['tl_metamodel_filtersetting']['text_palettes']['translatedtext'] =
    &$GLOBALS['TL_DCA']['tl_metamodel_filtersetting']['text_palettes']['_translated_'];

but the filter text is loaded before translatedtext :(

@zonky2 zonky2 force-pushed the hotfix_issue_#1203_add_all_langs_option branch from 0140e18 to f5b5645 Compare March 7, 2018 11:57
@zonky2 zonky2 changed the title [WIP] hotfix issue #1203 add all_langs option [RTM] hotfix issue #1203 add all_langs option Mar 7, 2018
@stefanheimes
Copy link
Copy Markdown
Member

stefanheimes commented Mar 8, 2018

Can you fix this or shoul i try it?

phpmd:
    [phpmd] /composer/vendor/metamodels/core/src/MetaModels/DcGeneral/Events/Table/FilterSetting/Subscriber.php:426  The method prepareSubPalettes() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
    [phpmd] /composer/vendor/metamodels/core/src/MetaModels/DcGeneral/Events/Table/FilterSetting/Subscriber.php:426  prepareSubPalettes accesses the super-global variable $GLOBALS.
    [phpmd] /composer/vendor/metamodels/core/src/MetaModels/DcGeneral/Events/Table/FilterSetting/Subscriber.php:426  prepareSubPalettes accesses the super-global variable $GLOBALS.
    [phpmd] /composer/vendor/metamodels/core/src/MetaModels/DcGeneral/Events/Table/InputScreens/Subscriber.php:58    The class Subscriber has an overall complexity of 82 which is very high. The configured complexity threshold is 80.

phpcs:
    [phpcs]
    [phpcs] FILE: ...rc/MetaModels/DcGeneral/Events/Table/InputScreens/Subscriber.php
    [phpcs] ----------------------------------------------------------------------
    [phpcs] FOUND 1 ERROR AFFECTING 1 LINE
    [phpcs] ----------------------------------------------------------------------
    [phpcs]  732 | ERROR | Parameter comment must end with a full stop
    [phpcs] ----------------------------------------------------------------------
    [phpcs]
    [phpcs] Time: 2.43 secs; Memory: 38Mb
    [phpcs]

@stefanheimes stefanheimes merged commit f5b5645 into MetaModels:hotfix/2.0.0-alpha18 Mar 8, 2018
stefanheimes added a commit that referenced this pull request Mar 8, 2018
@stefanheimes
Merge PR #1204 from zonky2
9727411
@zonky2 zonky2 mentioned this pull request Mar 8, 2018
Closed
4 tasks
discordier added a commit that referenced this pull request Mar 10, 2018
@discordier
Merge tag '2.0.0'
bcde048 
Stable release 2.0.0

In addition to all the changes in the previous betas, this release
contains the following fixes and enhancements.

Fixes:
- MySQL strict mode fixes.
- Many language strings are updated.
- Language strings for system columns have been moved from
  attribute_alias to the core (see MetaModels/attribute_alias#22).
- Support for responsive image sizes has been added (#1211).
- Optimization in backend CSS (see #1174).
- Bugfix in file sorting by file name (#1217).
- Huge refactorings in all places to finally reduce the complexity
  of all classes into acceptable ranges.
- Fixes for various minor issues and glitches (#1139, #1138)
- Add label and description for filter items (#1221)
- The URL parameter of filter settings has been moved to the
  "frontend filter" backend section.
- The search in "all languages" checkbox has been restored for
  searching in translated attributes (#1203, #1204).
- The "edit all/override all" button has been disabled for input
  screens.
- Do not override multiple for table "tl_metamodel" (#1223).
- The setting "skipfilteroptions" in filter settings now defaults to
  "off" (PR: #1224, discussion in #1089).

Enhancements:
- The feature "edit all" and "override all" which has been added to
  dc-general recently is supported now (#1196, #1098,
  contao-community-alliance/dc-general#359).
- Attribute types are now sorted with first the non-translated ones
  followed by the translated ones in the attribute edit mask in the
  type selection widget (#1219).
- The minimum versions of all dependencies have been raised to the
  current stable versions available.
discordier added a commit that referenced this pull request Mar 10, 2018
@discordier
Merge tag '2.0.0'
33d62fd 
Stable release 2.0.0

In addition to all the changes in the previous betas, this release
contains the following fixes and enhancements.

Fixes:
- MySQL strict mode fixes.
- Many language strings are updated.
- Language strings for system columns have been moved from
  attribute_alias to the core (see MetaModels/attribute_alias#22).
- Support for responsive image sizes has been added (#1211).
- Optimization in backend CSS (see #1174).
- Bugfix in file sorting by file name (#1217).
- Huge refactorings in all places to finally reduce the complexity
  of all classes into acceptable ranges.
- Fixes for various minor issues and glitches (#1139, #1138)
- Add label and description for filter items (#1221)
- The URL parameter of filter settings has been moved to the
  "frontend filter" backend section.
- The search in "all languages" checkbox has been restored for
  searching in translated attributes (#1203, #1204).
- The "edit all/override all" button has been disabled for input
  screens.
- Do not override multiple for table "tl_metamodel" (#1223).
- The setting "skipfilteroptions" in filter settings now defaults to
  "off" (PR: #1224, discussion in #1089).

Enhancements:
- The feature "edit all" and "override all" which has been added to
  dc-general recently is supported now (#1196, #1098,
  contao-community-alliance/dc-general#359).
- Attribute types are now sorted with first the non-translated ones
  followed by the translated ones in the attribute edit mask in the
  type selection widget (#1219).
- The minimum versions of all dependencies have been raised to the
  current stable versions available.
discordier added a commit that referenced this pull request Dec 19, 2018
@discordier
Merge tag 2.0.0
f3b02fd 
Stable release 2.0.0

In addition to all the changes in the previous betas, this release
contains the following fixes and enhancements.

Fixes:
- MySQL strict mode fixes.
- Many language strings are updated.
- Language strings for system columns have been moved from
  attribute_alias to the core (see MetaModels/attribute_alias#22).
- Support for responsive image sizes has been added (#1211).
- Optimization in backend CSS (see #1174).
- Bugfix in file sorting by file name (#1217).
- Huge refactorings in all places to finally reduce the complexity
  of all classes into acceptable ranges.
- Fixes for various minor issues and glitches (#1139, #1138)
- Add label and description for filter items (#1221)
- The URL parameter of filter settings has been moved to the
  "frontend filter" backend section.
- The search in "all languages" checkbox has been restored for
  searching in translated attributes (#1203, #1204).
- The "edit all/override all" button has been disabled for input
  screens.
- Do not override multiple for table "tl_metamodel" (#1223).
- The setting "skipfilteroptions" in filter settings now defaults to
  "off" (PR: #1224, discussion in #1089).

Enhancements:
- The feature "edit all" and "override all" which has been added to
  dc-general recently is supported now (#1196, #1098,
  contao-community-alliance/dc-general#359).
- Attribute types are now sorted with first the non-translated ones
  followed by the translated ones in the attribute edit mask in the
  type selection widget (#1219).
- The minimum versions of all dependencies have been raised to the
  current stable versions available.
@zonky2 zonky2 deleted the hotfix_issue_#1203_add_all_langs_option branch January 10, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@discordier discordier Awaiting requested review from discordier

@baumannsven baumannsven Awaiting requested review from baumannsven

Assignees

No one assigned

Labels

bug A bug! A bug! Fast, squish it!

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zonky2 @stefanheimes