Remove unused test code#1284
Merged
NicolasDorier merged 1 commit intoMetacoSA:masterfrom Oct 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While going through the test code, I've noticed that parts of the test code being unused. In particular, the
aandexpectedvariables. I grep'ed for all occurrences of the following lines in the test code and skimmed through the files for more unused code:C# not being my home turf, I did not manage to quickly get a static analysis run against the test code to find other cases and prevent this in the future.
This test in my branch 6.0 with netstandard2.0 failed first, but succeeded on a manual trigger - not sure how deterministic are the tests then.