Skip to content

Remove unused test code#1284

Merged
NicolasDorier merged 1 commit intoMetacoSA:masterfrom
quapka:dead-testcode
Oct 21, 2025
Merged

Remove unused test code#1284
NicolasDorier merged 1 commit intoMetacoSA:masterfrom
quapka:dead-testcode

Conversation

@quapka
Copy link
Contributor

@quapka quapka commented Oct 14, 2025

While going through the test code, I've noticed that parts of the test code being unused. In particular, the a and expected variables. I grep'ed for all occurrences of the following lines in the test code and skimmed through the files for more unused code:

var a =
var b =
var expected =

C# not being my home turf, I did not manage to quickly get a static analysis run against the test code to find other cases and prevent this in the future.

This test in my branch 6.0 with netstandard2.0 failed first, but succeeded on a manual trigger - not sure how deterministic are the tests then.

@NicolasDorier NicolasDorier merged commit 14619a9 into MetacoSA:master Oct 21, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants