This repository was archived by the owner on Feb 27, 2020. It is now read-only.
Conversation
… the spec-defined value)
ghost
assigned
Contributor
|
Does changing this list change the AVPs we are able to add on MMR/SAR messages (and UAR and LIR requests in future)? Presumably we can't include AVPs from vendors we don't support in messages we send. Otherwise code look fine. |
Contributor
Author
|
We currently only use AVPs from the 3GPP "vendor". All of the AVPs we're planning to use on UAR or LIR are also from 3GPP. In other words, I think we're OK here. |
Contributor
|
Very well. |
bossmc
added a commit
that referenced
this pull request
Nov 21, 2013
[Reviewer: Andy] Make the list of supported Cx vendor IDs configurable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117
Andy, please can you review my fix to make the list of supported Cx vendor IDs configurable. It can now be overridden in
local_settings.pyto remove ETSI from the list. I've tested both the default behavior and the overridden behavior against OpenIMS HSS and checked the flows are as expected and that OpenIMS HSS accepts them.