Skip to content

Wind speed and explicit aggregations - #203

Merged
jonasbhend merged 25 commits into
mainfrom
feat/wind-speed
Jul 20, 2026
Merged

Wind speed and explicit aggregations#203
jonasbhend merged 25 commits into
mainfrom
feat/wind-speed

Conversation

@jonasbhend

@jonasbhend jonasbhend commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

This PR implements both derived parameters (e.g. wind speed from eastward and northward components) and explicit handling of aggregation periods. The latter allows us to evaluate hourly, 6-hourly and daily precipitation in the same evalml experiment or meteogram run.

Out of scope

Adopt the novel funtionality for plotting of animations of forecast fields. This is a somewhat larger refactor due to the different data layout and combination of high-resolution inner and global outer domain necessary for forecast maps.

Summary of changes

  • Handle derived parameters in data_input
  • Explicit aggregations for precipitation

Example output

TOT_PREC1 TOT_PREC6
202503100000_TOT_PREC1_KLO 202503100000_TOT_PREC6_KLO
image Example dashboard: file:///M:/zue-prod/fc_development/seamless/S-RUC/evaluation/MRB-855_dashboard.html

@jonasbhend
jonasbhend marked this pull request as ready for review July 2, 2026 12:58
@dnerini

dnerini commented Jul 3, 2026

Copy link
Copy Markdown
Member

Very cool, thanks for this much needed feature! The PR looks already very mature, I just wonder whether we could already use it to integrate over plain variables too? Eg 24h min/max temperature? Or would you say this is out of scope?

@jonasbhend

Copy link
Copy Markdown
Contributor Author

Very cool, thanks for this much needed feature! The PR looks already very mature, I just wonder whether we could already use it to integrate over plain variables too? Eg 24h min/max temperature? Or would you say this is out of scope?

Good suggestion, I will have a look. Two things though:

  1. daily minimum and maximum temperatures are not the same as daily minimum and maximum of the hourly instantaneous temperatures. So in essence we should at least think about modelling these separately in the long term.
  2. The current aggregation is rolling, i.e. moving window. This is a bit counter to the daily min/max application, but maybe it is not too hard to integrate, I just don't know yet.

@dnerini

dnerini commented Jul 6, 2026

Copy link
Copy Markdown
Member

Good point! So maybe a better scope for this PR could be to stick to a rolling type of aggregation, eg 24h min/max/mean temperature?

@jonasbhend

Copy link
Copy Markdown
Contributor Author

That we could definitely do, yes. And if you select the 00 UTC timestamps, you basically have daily min/max

@jonasbhend

jonasbhend commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

I was to quick there. No I don't think adding maximum / minimum temperature is a good idea as we do not support different aggregating functions. The current PR works for sunshine duration, precipitation, etc., but I would suggest we can discuss and implement alternative aggregation functions in a separate PR. It's a good point though, as we will need to support alternative aggregation functions for wind gusts, temperature, etc. Moving window aggregation, however, is not very efficient. Here it works because for sums, you can just use the cumsum / lagged-diff trick.

Comment thread src/data_input/__init__.py Outdated
Comment thread src/data_input/__init__.py Outdated
Comment thread workflow/scripts/verification_scoremaps.py Outdated
Comment thread workflow/scripts/verification_scoremaps.py
Comment thread src/data_input/__init__.py

@clairemerker clairemerker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI assisted review ;)

I added a few comments, feel free to address or not!

@jonasbhend jonasbhend mentioned this pull request Jul 11, 2026
@jonasbhend
jonasbhend merged commit 1536b71 into main Jul 20, 2026
4 checks passed
@jonasbhend
jonasbhend deleted the feat/wind-speed branch July 24, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants