fix: GUI Animations being affected by fps#6383
Merged
Merged
Conversation
Collaborator
|
tick delta is supposed to be the correct metric for this, the logic was broken when updating from 1.21.11 to 26.1 i believe the issue stems from edit: yup, switching those fixes the issue |
Contributor
Author
updated the pr to fix the actual issue 👍 |
crosby-moe
approved these changes
May 5, 2026
Big-Iron-Cheems
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
GUI animations were running with the wrong delta after the 26.1 update.
GuiRendererMixin#draw$executeDrawRangewas passingDeltaTracker#getGameTimeDeltaPartialTick, but the GUI animation code expects tick deltas fromDeltaTracker#getGameTimeDeltaTicks.This restores the correct delta source so GUI animations run at the intended speed again.
Related issues
None
How Has This Been Tested?
Before:
trimmed3.mp4
After:
trimmed4.mp4
Checklist: