Skip to content

fix: GUI Animations being affected by fps#6383

Merged
Wide-Cat merged 3 commits into
MeteorDevelopment:masterfrom
rdbtCVS:master
May 6, 2026
Merged

fix: GUI Animations being affected by fps#6383
Wide-Cat merged 3 commits into
MeteorDevelopment:masterfrom
rdbtCVS:master

Conversation

@rdbtCVS
Copy link
Copy Markdown
Contributor

@rdbtCVS rdbtCVS commented May 5, 2026

Type of change

  • Bug fix
  • New feature

Description

GUI animations were running with the wrong delta after the 26.1 update. GuiRendererMixin#draw$executeDrawRange was passing DeltaTracker#getGameTimeDeltaPartialTick, but the GUI animation code expects tick deltas from DeltaTracker#getGameTimeDeltaTicks.

This restores the correct delta source so GUI animations run at the intended speed again.

Related issues

None

How Has This Been Tested?

Before:

trimmed3.mp4

After:

trimmed4.mp4

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@crosby-moe
Copy link
Copy Markdown
Collaborator

crosby-moe commented May 5, 2026

tick delta is supposed to be the correct metric for this, the logic was broken when updating from 1.21.11 to 26.1

i believe the issue stems from GuiRendererMixin#draw$executeDrawRange using DeltaTracker#getGameTimeDeltaPartialTick when before it used DeltaTracker#getGameTimeDeltaTicks

edit: yup, switching those fixes the issue

@rdbtCVS
Copy link
Copy Markdown
Contributor Author

rdbtCVS commented May 5, 2026

tick delta is supposed to be the correct metric for this, the logic was broken when updating from 1.21.11 to 26.1

i believe the issue stems from GuiRendererMixin#draw$executeDrawRange using DeltaTracker#getGameTimeDeltaPartialTick when before it used DeltaTracker#getGameTimeDeltaTicks

edit: yup, switching those fixes the issue

updated the pr to fix the actual issue 👍

@rdbtCVS rdbtCVS changed the title fix: make GUI animations time based instead of tick delta based fix: GUI Animations being affected by fps May 6, 2026
@Wide-Cat Wide-Cat merged commit d27af94 into MeteorDevelopment:master May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants