Skip to content

prevent profile imports overwriting other profiles#6502

Merged
Wide-Cat merged 2 commits into
MeteorDevelopment:masterfrom
noramibu:prevent-profile-imports-overwriting-other-profiles
Jul 2, 2026
Merged

prevent profile imports overwriting other profiles#6502
Wide-Cat merged 2 commits into
MeteorDevelopment:masterfrom
noramibu:prevent-profile-imports-overwriting-other-profiles

Conversation

@noramibu

@noramibu noramibu commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix
  • New feature

Description

This is just a simple tightening patch for profile import path validation. The previous commit fixed the actual issue, but that still allowed traversal into other profiles using NBT keys like ../OtherProfile/modules.nbt.

Related issues

Partially #6500

How Has This Been Tested?

Tested with a profile which overwrites another profiles, profile is shared on discord

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@noramibu noramibu marked this pull request as draft July 2, 2026 15:21
@noramibu noramibu marked this pull request as ready for review July 2, 2026 15:35
@Wide-Cat Wide-Cat merged commit 6b7a109 into MeteorDevelopment:master Jul 2, 2026
1 check passed
Wide-Cat pushed a commit that referenced this pull request Jul 2, 2026
Wide-Cat pushed a commit that referenced this pull request Jul 2, 2026
@crosby-moe crosby-moe mentioned this pull request Jul 3, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants