Misalignment Fixes#310
Merged
ldeniau merged 1 commit intoMethodicalAcceleratorDesign:devfrom May 21, 2023
Merged
Conversation
Contributor
jgray-19
commented
May 17, 2023
jgray-19
commented
- Add edir to dynmap
- Remove multiplication of tdir and sdir in translate (done in the actual function)
- Change sdir to tdir in geomap for rotation (like above)
- Add tdir and sdir multiplications in translate for geomap (translate is only the matrix)
ldeniau
approved these changes
May 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.