Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
I have updated the changelog with all the missing entries from previous PRs
@nabilgyoussef I'll let you complete the CCGT section with your modifications on CCGT side
Proposed Release notes
Some minor changes not written here are detailed in Changelog
Common changes
adiabatic_compressionoption anymoreNPP specific
heater.tube_rupture.Qifheateris declared withfaulty=trueparameter, see Internal leaks in heaters #306. The same is true for all heaters inWaterSteam.HeatExchangerpackage-> If you maintain a client model and want to use this version, you will have to modify the faulty model only, by removing all the internal heaters leaks (tube rupture and separating plate leak), and assign variables to internal variables defined
CCGT specific
AirCompressorcomponent have been corrected: models of previous versions should be adapted for compatibility. The isentropic efficiency's order of magnitude changed: calibrated efficiency with the previous version of the library will definitely give wrong values for the outlet temperature and power consumption of the compressor Correction of the isentropic state of the compressor #311NTUHeatExchangenow have the counter current flow configuration. Moreover, it is now possible not to predefine theQCpMAXside: the model can check by itself. Ntu countercurrent #304Sourceof theFuelMediumcan now accept the molar fraction of the composition instead of the mass fraction: the conversion is made directly in the component. Fuel source molar fraction #309CombustionChambercan now calculate the LHV and HHV from the composition. However, if the LHV or HHV are given, it can be assigned in the modifier of theCombustionChambercomponent. Combustion Chamber Improvement #310Type of change
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.