Skip to content

Conversation

@pierre-eliep-met
Copy link
Collaborator

@pierre-eliep-met pierre-eliep-met commented Nov 30, 2022

Goal

I have updated the changelog with all the missing entries from previous PRs

@nabilgyoussef I'll let you complete the CCGT section with your modifications on CCGT side

Proposed Release notes

Some minor changes not written here are detailed in Changelog

Common changes

  • Pumps do not have an adiabatic_compression option anymore

NPP specific

  • All heaters leaks are now modeled inside the heater, meaning that you have to specify heater.tube_rupture.Q if heater is declared with faulty=true parameter, see Internal leaks in heaters #306. The same is true for all heaters in WaterSteam.HeatExchanger package
  • Leaks can now have non-SI units after adding units in leaks #314, to which you can have access in the same way as you do with sensors

-> If you maintain a client model and want to use this version, you will have to modify the faulty model only, by removing all the internal heaters leaks (tube rupture and separating plate leak), and assign variables to internal variables defined

CCGT specific

  • The isentropic state in the AirCompressor component have been corrected: models of previous versions should be adapted for compatibility. The isentropic efficiency's order of magnitude changed: calibrated efficiency with the previous version of the library will definitely give wrong values for the outlet temperature and power consumption of the compressor Correction of the isentropic state of the compressor #311
  • The NTUHeatExchange now have the counter current flow configuration. Moreover, it is now possible not to predefine the QCpMAX side: the model can check by itself. Ntu countercurrent #304
  • The Source of the FuelMedium can now accept the molar fraction of the composition instead of the mass fraction: the conversion is made directly in the component. Fuel source molar fraction #309
  • The CombustionChamber can now calculate the LHV and HHV from the composition. However, if the LHV or HHV are given, it can be assigned in the modifier of the CombustionChamber component. Combustion Chamber Improvement #310

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Release & Version Update (when cumulative changes justify a release)
  • Documentation Update

Checklist

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

  • I have added the appropriate tags, reviewers, projects and linked issues to this PR
  • I have performed a self-review of my own code
  • Existing tests pass.
  • I have added/updated tests that prove my development works and does not break anything.
  • I have made corresponding changes or additions to the documentation
  • I have added corresponding entries to the Changelog
  • I have checked for conflicts with target branch, and merged/rebased in consequence

@pierre-eliep-met pierre-eliep-met added the 💔 No retro compatibility For changes that break retrocompatibility label Nov 30, 2022
@pierre-eliep-met pierre-eliep-met changed the title Added missing entries in changelog Bump to v3.1.0 Nov 30, 2022
@pierre-eliep-met pierre-eliep-met merged commit a8928b5 into main Nov 30, 2022
@pierre-eliep-met pierre-eliep-met deleted the bump-to-v3.1 branch November 30, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💔 No retro compatibility For changes that break retrocompatibility 🔖release Release / Version tags

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants