Internal leaks in heaters #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
valentind-met
requested review from
hadrienp-met,
helenev-met,
moritzn-met,
nabily-met and
pierre-eliep-met
moritzn-met
approved these changes
Nov 3, 2022
Contributor
moritzn-met
left a comment
moritzn-met
left a comment
There was a problem hiding this comment.
All checked and approved!
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
valentind-met
added a commit
that referenced
this pull request
Nov 28, 2022
* adding units in leaks * updating changelog * Internal leaks in heaters (#306) * adding internal leak to reheater and dryreheater * dryreheater corrections * corrected flow rate sign unit Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech> * internal leaks in superheater * update changelog * corrected min modifier in superheater Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech> Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech> Co-authored-by: pepmts <pierre-elie.personnaz@metroscope.tech> * impprove test values Co-authored-by: pepmts <97044708+pepmts@users.noreply.github.com> * adding units in leaks * updating changelog * impprove test values Co-authored-by: pepmts <97044708+pepmts@users.noreply.github.com> Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech> Co-authored-by: pepmts <pierre-elie.personnaz@metroscope.tech> Co-authored-by: pepmts <97044708+pepmts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adding internal leaks in heaters, using faulty variables. Faults added in : Reheater (tube rupture + separation plate), Superheater (tube rupture) and DryReheater (tube rupture + separation plate).
This change impacts current faulty models.
This PR also changes the variables
Q_coldandQ_hotof these heaters, with new variablesQ_cold_inandQ_cold_out(etc) to acount for the fact that the inlet cold flow is not the same as the outlet cold flow when there is internal leakage. This PR could therefore impact models that use these variables.Type of change
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.