Feat/standadized - #997
Merged
Merged
Conversation
|
@nafiuishaaq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ GraphQL Successfully Removed (Option B Implemented)
1. Deleted GraphQL Resolver Files
src/users/users.resolver.ts- Deletedsrc/properties/properties.resolver.ts- Deletedcloses #905
2. Removed GraphQL-Specific Auth Infrastructure
src/auth/guards/gql-auth.guard.ts- Deletedsrc/auth/decorators/gql-user.decorator.ts- Deletedcloses #906
3. Cleaned up AppModule
GraphQLModule,ApolloDriver,ApolloDriverConfigimportsjoinfrom path4. Updated Properties Module
PropertiesResolverimport and providerPubSubimport and PUB_SUB provider that was used for GraphQL subscriptionscloses #907
5. Updated Users Module
UsersResolverimport and providercloses #908
6. All REST API Controllers Intact
The fully implemented REST API remains completely functional with all 40+ controllers still in place, including:
🚀 Current State
The project now exclusively uses REST APIs which are fully implemented across all entities, with no leftover GraphQL stubs or incomplete implementations. The codebase is cleaner and focused on the working REST architecture that has complete controller implementations for all entities.