Issues #1034 , #1035, #1036 , and #1037 handle and test: add missing pool, auction, oracle ACL, and collateral-event coverage - #1082
Merged
Conversation
…erage (MettaChain#1034-MettaChain#1037) Issue MettaChain#1034 - Lending pool-management tests (propchain-lending) - Add test_create_pool_unauthorized: non-admin create_pool returns Unauthorized - Add test_deposit_increases_total_deposits: deposit accounting is tracked - Add test_borrow_rejected_when_exceeds_deposits: pool-limit rejection path - Add test_deposit_and_borrow_accounting: sequential deposit/borrow round-trip - Add test_deposit_pool_not_found: unknown pool returns PoolNotFound - Move ink_e2e dev-dep behind e2e-tests feature to fix pre-existing trie-db/nightly incompatibility that blocked cargo test Issue MettaChain#1035 - Fractional Dutch-auction end-state tests (fractional) - Add test_dutch_auction_settlement_transfers_shares: share balances settle correctly after a winning bid (seller loses, buyer gains) - Add test_dutch_auction_price_decay_at_three_quarters: linear decay verified at 75% of duration - Add test_dutch_auction_exact_payment_succeeds: boundary — exact payment accepted - Add test_dutch_auction_second_bidder_receives_already_bid_error: one-shot AuctionAlreadyBid guard on an already-won auction - Add test_dutch_auction_payment_one_below_minimum_rejected: payment 1 unit below total is rejected with InsufficientPayment Issue MettaChain#1036 - Oracle access-control and TTL tests (oracle) - Add test_set_cache_ttl_by_admin_succeeds: admin/OracleAdmin can set TTL - Add test_set_cache_ttl_unauthorized_fails: non-admin rejected Unauthorized - Add test_grant_oracle_admin_role_and_use_ttl: granted OracleAdmin can call admin-gated messages - Add test_grant_role_requires_admin: only Admin-role holders can grant roles - Add test_add_oracle_source_unauthorized_rejection: role gate on a second admin-gated message (add_oracle_source) - Move ink_e2e dev-dep behind e2e-tests feature (same trie-db fix as lending) Issue MettaChain#1037 - Property-management collateral-event tests (property-management) - Wire collateral_events module into lib.rs with pub mod collateral_events (it was never compiled — the 2 existing tests were silently skipped) - Add test_event_preserves_assigned_at_timestamp - Add test_event_fields_match_inputs_exactly - Add test_multiple_events_for_same_property_are_independent - Add test_activation_then_deactivation_events_are_independent - Add test_zero_assigned_at_is_accepted Test results: cargo test -p propchain-lending 56 passed, 0 failed cargo test -p fractional 55 passed, 0 failed cargo test -p oracle 67 passed, 0 failed cargo test -p property-management 22 passed, 0 failed
|
@Agaki00 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Agaki00
changed the title
nanaf6203-bit
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Closes #1034 - Lending pool-management tests (propchain-lending)
Closes #1035 - Fractional Dutch-auction end-state tests (fractional)
Closes Oracle access-control and TTL messages are untested: role gates and set_cache_ttl are uncovered #1036 - Oracle access-control and TTL tests (oracle)
Closes #1037 - Property-management collateral-event tests (property-management)
Test results:
cargo test -p propchain-lending 56 passed, 0 failed
cargo test -p fractional 55 passed, 0 failed
cargo test -p oracle 67 passed, 0 failed
cargo test -p property-management 22 passed, 0 failed
Related Issues