Implementation complete - #842
Merged
Merged
Conversation
|
@ykargeee-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #747
The code is correct. The module uses use super::*; (line 20) which brings BasisPoints into scope, and it's used on line 23 (BasisPoints::DENOM) and now on lines 663-664 (BasisPoints::new()). The remaining warning is likely a stale LSP diagnostic.Here's a summary of the three fixes applied:
Closes #748
Lines 663-664: Wrapped old_rate and new_rate (both u32) with BasisPoints::new(...) to match the BasisPoints type expected by the FeeRateUpdated event fields.
Line 681: Changed config.base_fee_bps as u64 to config.base_fee_bps.get() as u64 — .get() extracts the inner u32 which can then be cast to u64.
Closes #749
Line 689: Changed .min(config.max_fee_bps) to .min(config.max_fee_bps.get()) — .get() extracts the inner u32 to match the u32 return type.
The BasisPoints import on line 7 is now actively used (via BasisPoints::new() on lines 663-664 and BasisPoints::DENOM on line 23), so the unused import warning should resolve once the LSP refreshes.
Closes #752