This repository was archived by the owner on Dec 31, 2025. It is now read-only.
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
|
yeah we didn't really define any types at the beginning so a lot of functions use string instead of the game type |
Contributor
|
@Jack5079 is this OK to merge? |
Contributor
Author
|
No I think it was half baked |
Contributor
Author
|
Remember we couldn't get localizedstring working for errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://corrode.dev/blog/illegal-state/ 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 I LOVE RUST 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 I LOVE TYPE SYSTEMS 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀
We should be using
Gamewhen we need a game andLocalizedStringwhen we are displaying translatable text