logs: report eval failures and fix stale logs on restart - #62
Merged
Conversation
Attach the evaluator's error tail to the nix-eval check run so a failed evaluation shows why without a click into the log. This threads through a new EvalReport dataclass, which also tidies the eval_finished signature. Fix a restart leaving the previous run's log in place: the row went pending but still served stale output until the rebuild reopened the log. Drop the log at reset time. Stop storing the log path. It is fully determined by (build_id, attr/effect name), so persisting it in logs.path and build_effects.log_path only let the row and the file drift. Compute the path in one place, keep only size/truncated metadata inline on the owning row (folding the logs table into build_attributes), treat file existence as "log exists", and reset by removing the file.
Mic92
force-pushed
the
drop-buildbot-migration-shims
branch
from
July 4, 2026 11:40
35ce1b4 to
704dad8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attach the evaluator's error tail to the nix-eval check run so a failed evaluation shows why without a click into the log. This threads through a new EvalReport dataclass, which also tidies the eval_finished signature.
Fix a restart leaving the previous run's log in place: the row went pending but still served stale output until the rebuild reopened the log. Drop the log at reset time.
Stop storing the log path. It is fully determined by (build_id, attr/effect name), so persisting it in logs.path and build_effects.log_path only let the row and the file drift. Compute the path in one place, keep only size/truncated metadata inline on the owning row (folding the logs table into build_attributes), treat file existence as "log exists", and reset by removing the file.