Conversation
Copilot
AI
changed the title
[WIP] Investigate Ethernet issue on NanoPi M6 after Linux upgrade
dt: rk3588s-nanopi-m6: add explicit rx_delay=0 for rgmii-rxid gmac1
Mar 13, 2026
Owner
|
Reason for failing Ethernet was handmade on my particular system, but the missing Copilot's analysis however is wrong: Reason for the error is that the value is checked unconditionally. But is it ignored in case og |
MichaIng
approved these changes
Mar 13, 2026
In Linux 7.0, the dwmac-rk.c driver changed to use the DTS-provided rx_delay value (defaulting to 0x10) instead of hardcoding 0 for RGMII_RXID mode. This broke Ethernet on NanoPi M6 which used rgmii-rxid mode but had no explicit rx_delay in its DTS. Add rx_delay = <0x00> to the gmac1 node to match the expected configuration for rgmii-rxid mode (where RX delay is handled by the RTL8211F PHY internally, not by the SoC), consistent with other working RK3588/RK3588S boards (hinlink-h88k, mixtile-core3588e, youyeetoo-r1). Co-Authored-By: MichaIng <28480705+MichaIng@users.noreply.github.com>
e88ceda to
e9efa11
Compare
It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com> Co-Authored-By: MichaIng <28480705+MichaIng@users.noreply.github.com>
MichaIng
pushed a commit
that referenced
this pull request
Mar 28, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 2, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 9, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 10, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 11, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 12, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 17, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 18, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 19, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 20, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 25, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 26, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
Apr 28, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
May 1, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
pushed a commit
that referenced
this pull request
May 2, 2026
) It causes a kernel error if missing, despite being ignored with rgmii-rxid mode: - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1276-L1285 - https://github.com/torvalds/linux/blob/b10d56b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c#L1433-L1438 Signed-off-by: MichaIng <micha@dietpi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NanoPi M6 Ethernet breaks on Linux 7.0 because
dwmac-rk.cchangedRGMII_RXIDhandling to usebsp_priv->rx_delay(defaulting to0x10) instead of hardcoding0, incorrectly applying SoC-side RX delay when the RTL8211F PHY already handles it internally.Change
rx_delay = <0x00>to&gmac1inrk3588s-nanopi-m6.dts, matching all other active RK3588/RK3588S boards usingrgmii-rxid(hinlink-h88k,mixtile-core3588e,youyeetoo-r1)&gmac1 { clock_in_out = "output"; phy-handle = <&rgmii_phy1>; phy-mode = "rgmii-rxid"; ... + rx_delay = <0x00>; tx_delay = <0x42>; status = "okay"; };Notes
The reporter also blacklisted
dwmac_rk, which is the actual driver forfe1c0000.ethernet— removing it from the blacklist is required regardless of this DTS fix. Thesync_state() pendingkernel log messages are a downstream effect of unprobed blacklisted drivers (GPU, VPU, HDMI, Ethernet) and are not themselves the cause of failure.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.