This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Fix issue where files to format list was getting truncated due to cas…#227
Merged
scottkurz merged 1 commit intoMicroShed:masterfrom Dec 17, 2018
Conversation
…e-sensitive var in hook script
uberskigeek
approved these changes
Dec 17, 2018
Contributor
uberskigeek
left a comment
uberskigeek
left a comment
There was a problem hiding this comment.
why was the case an issue?
Contributor
Author
|
@uberskigeek - if you look at the diff quick it probably just looks like I have a loveOfCamelCaseOrSomething :) The problem though was the one var on line 84 that was camelcase while the others were NOT, since this was resulting in a totally separate variable. But since the other vars in the script were camel case I just fixed this one to be, in making it consistent. |
Contributor
|
That would be a problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e-sensitive var in hook script