Devel#56
Merged
wesleywesley merged 6 commits intomasterfrom Jan 8, 2019
Merged
Conversation
The reinit of shared MW when receive FORCE_LINK_DOWN message is required for non-crosslink case, because the LUT settings for shared MW of peer is reset after reboot. But in crosslink case, the LUT setttings in the virtual partition will not be impact by the peer's reboot, therefore it is unnecessary to reinit it. Signed-off-by: Wesley Sheng <wesley.sheng@microchip.com>
Remove ternary operator which doesn't make sense This commit was response of feedback from Bjorn Helgaas in the procedure of upstream. https://lore.kernel.org/patchwork/patch/1023094/ Signed-off-by: Wesley Sheng <wesley.sheng@microchip.com>
There exists a corner case: MRPC completion event happened immediately after other non-MRPC event, moreover exactly right after MRPC event occurrence check but before the mask event loop reach to its header register in event ISR, the MRPC event would be masked unintentionally. Since there's no chance to enable it again except module remove and install, all the following MRPC execution completion check will be defer to timeout. Fix this bug by bypass the mask operation same as to LINK event in event ISR. This corner case was exposed by concurrently running fw-update and event-wait commands of switchtec-user. When it happened, firmware update speed reduce evidently. Signed-off-by: Wesley Sheng <wesley.sheng@microchip.com>
switchtec: Fix unintended mask of MRPC event
ntb_hw_switchtec: remove unnecessary shared MW reinit in crosslink case
switchtec: Remove unnecessary ternary operator
Contributor
Author
|
merge to master for release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.