Skip to content

Conversation

@cliffbird
Copy link

The first device underneath a switch does not obtain all its status information because the glob search matches more than one entry (line 429). For example:

$ ls -l /sys/devices/pci0000:00/0000:00:01.1/0000:01:00.0/
total 0
drwxr-xr-x  3 root root    0 Oct  3 21:59 0000:01:00.0:pcie102  <-----
drwxr-xr-x 12 root root    0 Oct  3 21:59 0000:02:00.0
drwxr-xr-x 12 root root    0 Oct  3 21:59 0000:02:01.0
drwxr-xr-x 12 root root    0 Oct  3 21:59 0000:02:02.0
drwxr-xr-x 12 root root    0 Oct  3 21:59 0000:02:03.0
drwxr-xr-x 10 root root    0 Oct  3 21:59 0000:02:04.0
drwxr-xr-x 11 root root    0 Oct  3 21:59 0000:02:05.0

The glob search will return both 0000:01:00.0:pcie102 and 0000:02:00.0 therefore pci_bdf for the device is not populated (see line 430).

Copy link
Collaborator

@lsgunth lsgunth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, hmm, that's strange that that device is there. But it looks like your patch should work around that issue fine.

Thanks!

@kelvin-cao kelvin-cao merged commit 6513448 into Microsemi:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants