Merged
Conversation
After the setup of dev->gen and dev->var, continue with the setup of dev->boot_phase.
Introduce a new function to get device id in BL2, as GAS regions is not populated in this boot phase.
The info command doesn't show variant and device ID properly in BL2, as current code get device ID from GAS which is not available in BL2. Fallback to MRPC if device ID is not returned.
F/W version is not available in BL1. Print 'N/A' for F/W version instead of exiting with error.
Report 'N/A' instead of '0x0000' or 'Unknown' for Device Id and Variant which are not available in BL1. Also show boot phase to make the reporting of 'N/A' more reasonable.
lsgunth
approved these changes
Nov 15, 2022
Collaborator
lsgunth
left a comment
lsgunth
left a comment
There was a problem hiding this comment.
One minor nit I noticed. Otherwise it looks good to me.
inc/switchtec/switchtec.h
Outdated
| /** | ||
| * @brief Return the phase string for a phase id. | ||
| */ | ||
| static inline const char* phase_id_to_string(enum switchtec_boot_phase phase_id) |
Collaborator
There was a problem hiding this comment.
Might be a good idea to rename this with a switchtec_prefix, or some such.
Collaborator
Author
There was a problem hiding this comment.
Updated, thanks for the review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally two fixes in this PR.
The updated output looks like below.