Support diag ltssm cmd for gen5 #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-cao
reviewed
Mar 26, 2025
kelvin-cao
reviewed
Mar 26, 2025
kelvin-cao
reviewed
Mar 26, 2025
kelvin-cao
reviewed
Mar 26, 2025
kelvin-cao
reviewed
Mar 26, 2025
kelvin-cao
reviewed
Mar 26, 2025
lsgunth
approved these changes
Mar 28, 2025
Collaborator
lsgunth
left a comment
lsgunth
left a comment
There was a problem hiding this comment.
Did a quick review, didn't find any issues. Thanks for many of the cleanups!
kelvin-cao
reviewed
Apr 2, 2025
kelvin-cao
reviewed
Apr 2, 2025
kelvin-cao
reviewed
Apr 2, 2025
kelvin-cao
reviewed
Apr 2, 2025
kelvin-cao
reviewed
Apr 2, 2025
lib/diag.c
Outdated
| log_data[curr_idx + i].timestamp = timestamp; | ||
| log_data[curr_idx + i].link_rate = switchtec_gen_transfers[rate+1]; | ||
| log_data[curr_idx + i].link_state = major | (minor << 8); | ||
| } |
Collaborator
There was a problem hiding this comment.
The logic of issuing MRPC and assigning retrieved log to log_data repeated several times in the code, possible to extract it to make it a helper function?
kelvin-cao
reviewed
Apr 2, 2025
lib/diag.c
Outdated
|
|
||
| rate = (dw0 >> 13) & SWITCHTEC_LTSSM_LOG_MASK_RATE; | ||
| major = (dw0 >> 7) & SWITCHTEC_LTSSM_LOG_MASK_MAJOR; | ||
| minor = (dw0 >> 3) & SWITCHTEC_LTSSM_LOG_MASK_MINOR; |
Collaborator
There was a problem hiding this comment.
If a helper function is possible, we probably can remove the mask macros and just expand the value in the statement, just as we put shift offset values here.
kelvin-cao
reviewed
Apr 2, 2025
lib/diag.c
Outdated
| int ret; | ||
| if (switchtec_is_gen5(dev)) { | ||
| ret = switchtec_diag_ltssm_log_gen5(dev, port, log_count, log_data); | ||
| } |
Collaborator
There was a problem hiding this comment.
Surrounding {} not necessary.
Added new set of function to handle gen5 ltssm log requests. Data structures to handle I/O of the MRPC data have been updated to gen5 structures and offsets. Sub command ID has been updated to gen5 subcommand IDs. Added buffering option for logs larger than 61 entries to send multiple ltssm MRPC commands as per the spec.
BenReed161
force-pushed
the
support-diag-ltssm-cmd-for-gen5
branch
from
b7b9ab1 to
4f86533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.