Add declarative syntax to menu items in fab-*-buttons#61
Merged
Conversation
…stom icon render the custom icon render doesn't work due to an office-ui-fabric-react bug
25c39eb to
04d9397
Compare
…imilar to how command bar items allow it
04d9397 to
d168704
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add a declarative syntax to all
fab-*-buttons components (fab-default-button,fab-action-buttonetc.) for declaring menu items:Also addresses
<contextual-menu-item>directive items not having a comparable declarative syntax for theirrenderandrenderIconinputs counterparts inIContextualMenuItem. Note that the overriding of an icon render doesn't work due to a bug inoffice-ui-fabric-react.Related issue: #3