Skip to content

Update upgrade-on-premises-infrastructure.md#2346

Merged
ktoliver merged 1 commit intoMicrosoftDocs:mainfrom
GambitC90:patch-1
Jan 13, 2022
Merged

Update upgrade-on-premises-infrastructure.md#2346
ktoliver merged 1 commit intoMicrosoftDocs:mainfrom
GambitC90:patch-1

Conversation

@GambitC90
Copy link
Copy Markdown
Contributor

This should be the SMS Node, not the CCM Node - I worked with a customer having this issue and the CCM Node shouldn't have SMS Admins added to it, but the SMS Node should.

This should be the SMS Node, not the CCM Node - I worked with a customer having this issue and the CCM Node shouldn't have SMS Admins added to it, but the SMS Node should.
@PRMerger15
Copy link
Copy Markdown
Contributor

@GambitC90 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver
Copy link
Copy Markdown
Contributor

#label:"aq-pr-triaged"

@PRMerger14 PRMerger14 added the aq-pr-triaged Tracking label for the PR review team label Jan 12, 2022
@aczechowski
Copy link
Copy Markdown
Contributor

LOL, this value is highly contested, it's flipped several times in the past several months

See my comment from 2120 with comment from engineering: #2120 (review)

So maybe the fix here is to note both with some more explanation.
Thanks @GambitC90 for the contribution, but I'm going to close this request, and I'll take an action later today to revise this bit with some more info.

@aczechowski
Copy link
Copy Markdown
Contributor

Had a side chat with Chris as I looked at this in more detail. I'm actually going to reopen and accept this PR, to help put the article back into the correct state.

Here's the history:

So then this PR is needed to fix line 108.

Thanks @GambitC90 😁

@aczechowski aczechowski reopened this Jan 13, 2022
@aczechowski
Copy link
Copy Markdown
Contributor

#label:"ready-to-merge"

@ktoliver ktoliver merged commit 06b71ec into MicrosoftDocs:main Jan 13, 2022
@GambitC90 GambitC90 deleted the patch-1 branch March 9, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants