[gdb] Fix bugs in GetCallStack and GetSymbolsInStackFrame #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Share the type formatting code with SFieldResult, to fix pointer handling. Also fixes a typo (s -> self) and correctly passes the symbol to SSymbolResult.
cbiesinger
changed the title
Collaborator
Author
|
I've repurposed this pull request to fix all the issues in GetCallStack and GetSymbolsInStackFrame; they work for me now when I call JsDbg.GetCallStack / JsDbg.LookupLocalsInStackFrame |
sanketj
approved these changes
May 6, 2019
|
|
||
| List<SStackFrame> result = new List<SStackFrame>(); | ||
|
|
||
| int index = 1; // Skip initial '"' character |
Contributor
There was a problem hiding this comment.
Was this just a bug before or has something changed such that now we don't see the '"' character?
Collaborator
Author
There was a problem hiding this comment.
I'm fairly sure that this is basically the same issue as #21
Maybe @MSLaguana could comment better
Contributor
There was a problem hiding this comment.
Yeah I think it is the same; probably from when I switched from parsing the gdb mi format to doing everything via python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77