Skip to content

API Review: PrintToPdf.md (#1522)#1682

Merged
vickiez merged 2 commits intomasterfrom
api-printtopdf
Sep 10, 2021
Merged

API Review: PrintToPdf.md (#1522)#1682
vickiez merged 2 commits intomasterfrom
api-printtopdf

Conversation

@vickiez
Copy link
Copy Markdown
Member

@vickiez vickiez commented Aug 24, 2021

  • print to pdf draft spec

  • update sample code to change setting

  • remove unused

  • internal review changes part 1

  • api spec changes part 2

  • update sample code

  • update documentation

Co-authored-by: Viktoria Zlatinova vizlatin@microsoft.com

* print to pdf draft spec

* update sample code to change setting

* remove unused

* internal review changes part 1

* api spec changes part 2

* update sample code

* update documentation

Co-authored-by: Viktoria Zlatinova <vizlatin@microsoft.com>
@vickiez vickiez requested a review from david-risney August 24, 2021 17:51
@vickiez vickiez added the API Proposal Review WebView2 API Proposal for review. label Aug 24, 2021
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md
Comment thread specs/PrintToPdf.md
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md
Comment thread specs/PrintToPdf.md
@dhoehna
Copy link
Copy Markdown

dhoehna commented Sep 2, 2021

Is there a way for the developer to see what the printed PDF will look like before printing, for testing purposes? I can't imagine a business would be happy with a developer printing out multiple PDF's.

Copy link
Copy Markdown
Contributor

@david-risney david-risney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md
Comment thread specs/PrintToPdf.md
Comment thread specs/PrintToPdf.md Outdated
Comment thread specs/PrintToPdf.md
@david-risney david-risney added the review completed WebView2 API Proposal that's been reviewed and now needs final update and push label Sep 7, 2021
@vickiez vickiez merged commit 81f86bb into master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Proposal Review WebView2 API Proposal for review. review completed WebView2 API Proposal that's been reviewed and now needs final update and push

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants