Conversation
* draft child process id spe * remove white space * add count * modify c# section * correct typo * add sample code c+ * add comment to c# * change wording of example * rename and use updated template * update sample * modify c++ sample * add c# sample * update with moving to environment * add background section * update interface * update API details section * d * modify enum and related change * change API naming * add custom type for .net * update with ICoreWebView2StagingProcessInfo * minor chang * fix lower case issue * change comment * update .NET sample code * remove staging prefix * update .NET sample code * update win32 sample code * rename * update sample code * change naming Co-authored-by: Diana Qu <xiaqu@microsoft.com>
david-risney
requested changes
Sep 28, 2021
added 2 commits
October 2, 2021 23:42
david-risney
requested changes
Oct 18, 2021
Contributor
david-risney
left a comment
david-risney
left a comment
There was a problem hiding this comment.
Please fix the issues in the IDL3 and I can create a review meeting. Thanks!
Co-authored-by: David Risney <dave@deletethis.net>
oldnewthing
reviewed
Oct 20, 2021
| WCHAR id[4096] = L""; | ||
| StringCchPrintf(id, ARRAYSIZE(id), L"Process ID: %u", processId); | ||
|
|
||
| HANDLE processHandle = OpenProcess(PROCESS_ALL_ACCESS, FALSE, processId); |
Contributor
There was a problem hiding this comment.
Handle is leaked. Save it in a wil::unique_process_handle.
Author
There was a problem hiding this comment.
Would it be okay if I just CloseHandle(processHandle)?
david-risney
requested changes
Oct 28, 2021
Contributor
david-risney
left a comment
david-risney
left a comment
There was a problem hiding this comment.
Please update per feedback. Thanks!
| WCHAR id[4096] = L""; | ||
| StringCchPrintf(id, ARRAYSIZE(id), L"Process ID: %u", processId); | ||
|
|
||
| HANDLE processHandle = OpenProcess(PROCESS_ALL_ACCESS, FALSE, processId); |
david-risney
added
the
review completed
added 7 commits
November 2, 2021 23:04
david-risney
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an API review for WebView2 Process Id