Add spec for CookieManagement.md#463
Add spec for CookieManagement.md#463peiche-ms merged 13 commits intoapi-cookie-management-interimfrom
Conversation
peiche-ms
changed the base branch from
master
to
api-cookie-management-interim
|
Thank you, looks good to me. |
|
So it's easier to handle your own downloads, can there be a function to convert to .Net cookie. |
|
There is HttpOnly property, so for sure we can create HttpOnly cookies, which is good thing. Will GetCookiesAsync return HttpOnly cookies as well? |
|
|
||
| void SetCookieCmdExecuted(object target, ExecutedRoutedEventArgs e) | ||
| { | ||
| CoreWebView2Cookie cookie = _cookieManager.CreateCookie("CookieName", "CookieValue", ".bing.com", "/"); |
There was a problem hiding this comment.
Is the '.' at the start of .bing.com necessary or have special meaning? The parameter is named 'domain' and I wouldn't offhand expect I need to put a '.' at the start of the parameter.
There was a problem hiding this comment.
It is necessary for CDP
There was a problem hiding this comment.
But what does it mean? Does it just mean 'bing.com'? AFAIK the empty domain name label is only valid for the root and is not allowed elsewhere in a domain name. Is this syntax specific to CDP? I don't see anything about this in the cookie spec. I also don't see anything about it in CDP docs (but that doesn't necessarily mean anything)
| } | ||
|
|
||
| /// A list of cookie objects. | ||
| runtimeclass CoreWebView2CookieList |
There was a problem hiding this comment.
In COM I understand having our own list type, but for .NET and WinRT can we use existing types from those languages/runtimes?
There was a problem hiding this comment.
For .NET, CoreWebView2CookieList should implement System.Collections.Generic.IList<CoreWebView2Cookie>; for WinRT, CoreWebView2CookieList should implement Windows.Foundation.Collections.IVector<CoreWebView2Cookie>.
| /// The default is the host that this cookie has been received from. | ||
| String Domain { get; }; | ||
|
|
||
| /// The path for which the cookie is valid. If not specified, this cookie |
There was a problem hiding this comment.
'not specified' here means empty string or null I guess right?
There was a problem hiding this comment.
Correct. Should say it explicitly in the comment?
…tor<CoreWebView2Cookie>
|
|
||
| void AddOrUpdateCookieCmdExecuted(object target, ExecutedRoutedEventArgs e) | ||
| { | ||
| CoreWebView2Cookie cookie = webView.CoreWebView2.CookieManager.CreateCookieWithDetails("CookieName", "CookieValue", ".bing.com", "/"); |
There was a problem hiding this comment.
What's with the prefix '.' on 'bing.com'? Is '.bing.com' different from 'bing.com'? If so, this needs a comment in the API documentation
|
|
| /// The expiration date and time for the cookie as the number of seconds since the UNIX epoch. | ||
| /// The default is -1.0, which means cookies are session cookies by default. | ||
| Double Expires { get; set; }; | ||
| Windows.Foundation.DateTime Expires { get; set; }; |
There was a problem hiding this comment.
Does this work in WPF/Winforms? I believe Windows.Foundation.DateTime is UWP only, isn't it? In case it is, then we should revert back to Double as the WebView2 control is available on WPF and on Winforms too.
There was a problem hiding this comment.
We use Windows.Foundation.DateTime for WinRT API only, and we use Double for .NET API.
There was a problem hiding this comment.
There's a datetime type in .NET also right? Can't we use the appropriate datetime type for .NET?
Updated |
david-risney
left a comment
david-risney
left a comment
There was a problem hiding this comment.
Looks ready for api review. Please open PR to master. Thanks!
7 participants
This is a review for the new Cookie Management APIs.