Add cycle-detection for nested env vars#27
Merged
Merged
Conversation
- Implement cycle detection in `resolve_value` by tracking seen results with a `HashSet`, seeded with the initial input to catch oscillations like `A=${B}` / `B=${A}`.
- Replace the per-iteration previous-value check with a set-based bailout that stops when the new result is the same as the current one or has already been seen, ensuring safe termination.
- Extend tests in `tests/resolve_nested_variables.rs` to cover circular dependencies, verifying two-way and three-way references terminate and leave unresolved placeholders intact (contain `${`), i.e., graceful degradation.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_valueby tracking seen results with aHashSet, seeded with the initial input to catch oscillations likeA=${B}/B=${A}.tests/resolve_nested_variables.rsto cover circular dependencies, verifying two-way and three-way references terminate and leave unresolved placeholders intact (contain${), i.e., graceful degradation.