Add CI workflow to run tests on every pull request#18
Merged
Conversation
Previously the only place dotnet test ran was inside deploy.yml, on push to master -- meaning a broken PR could merge with no automated signal, only discovered afterward when deploy.yml failed on master. This adds a dedicated ci.yml that runs build+test on pull_request (and push to master, for a clean pass/fail signal independent of deploy.yml's deployment-specific concerns like Tailscale/SSH). Leaves deploy.yml's own test step in place as a deploy-time safety net. Verified the exact restore/build/test commands the workflow runs succeed locally against Release configuration (83/83 tests passing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlrunsdotnet build+dotnet teston every pull request (and on push to master) — closes the gap where tests only ran indeploy.yml, meaning a broken PR could merge with no automated signal until it had already landed and the deploy failed afterward.deploy.yml, which keeps its own test step as a deploy-time safety net and also gives a clean "tests pass" signal separate from deployment-specific failures (Tailscale/SSH issues, etc.) that would otherwise show up as a red X on the same check.Test plan
dotnet restore/build --configuration Release/test --no-build --configuration Releasecommands the workflow runs succeed locally (83/83 tests passing)ci.ymlcheck actually appears and passes on this PR (self-verifying)Optional follow-up: enable a branch protection rule on
masterrequiring theCI / testcheck to pass before merging, so this becomes an enforced gate rather than just a visible signal.