Require a branch + PR for all changes#28
Merged
Conversation
Codifies a workflow preference the user gave after this session's Details-link fix went straight to master, bypassing master's required "test" status check. A PR is what actually runs dotnet test before anything lands. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CfWmHii9XYmPNBhz5dGDxZ
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Comment on lines
+159
to
+162
| push straight to `master`, and do not merge a PR yourself unless explicitly told to. `master`'s | ||
| branch protection allows this repo's owner to bypass its required "test" status check, but | ||
| bypassing it skips CI entirely — a PR is what actually runs `dotnet test` before anything lands. | ||
|
|
There was a problem hiding this comment.
Factual inaccuracy: "bypassing it skips CI entirely" isn't accurate for this repo. .github/workflows/deploy.yml triggers on every push to master and has its own dotnet test step (a deploy-time safety net), and .github/workflows/ci.yml's test job also triggers on push: branches: [master] in addition to pull_request. So a direct push to master still runs dotnet test in both workflows — it just isn't gated before the push lands. The rationale here would be more accurate as something like "bypassing it skips the pre-merge gate — tests still run post-push in deploy.yml/ci.yml, but a broken change can already be on master by the time they fail."
Lines 159 to 162 in 29a2cc5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This session's Details-link fix went straight to master, bypassing the required "test" status check. The user asked to always use PRs going forward so CI actually gates changes.
Test plan
https://claude.ai/code/session_01CfWmHii9XYmPNBhz5dGDxZ