Reconcile CLAUDE.md NuGet policy with actual project state#8
Merged
Conversation
Rule #4's header still read as a blanket ban after the body text was loosened to allow packages with permission; retitled for consistency. Its "currently uses only" package list was also stale — Serilog was added at some point and never reflected here. Softened the "no Newtonsoft" line too: it was never a hard rule with a specific incident behind it, just a since-day-one preference to avoid a second JSON library when System.Text.Json already covers everything — not a ban if something genuinely needs it. Reconsidered Rule #3 (no Twilio SDK) under the relaxed policy and confirmed it still holds, but on narrower grounds: independent of Newtonsoft, the official SDK also pulls in IdentityModel/JWT packages for auth flows this app doesn't use (Basic auth only) — real dependency weight for no gain over the existing ~50-line REST call.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Serilog.Extensions.Hosting,Serilog.Sinks.Console,Serilog.Sinks.File) has been in.csproj/Program.cssince day one but was never listed.Microsoft.IdentityModel.Tokens/System.IdentityModel.Tokens.Jwtfor API-key/JWT auth flows this app doesn't use (Basic auth only). Real dependency weight for zero gain over the existing ~50-line REST call.docs/plans/wssi-monitoring.md.Test plan