Fix variables in finally blocks not getting renamed#105
Merged
Conversation
4 tasks
jaskarth
pushed a commit
to Vineflower/vineflower
that referenced
this pull request
Jun 20, 2026
* Add missing instruction offsets * Revert of MinecraftForge/ForgeFlower/pull/105 Revert of d88f743 Fixes #596 * temp undo * Fix dec file issues * Update kotlin dec file
hourianto
pushed a commit
to hourianto/sporeflower
that referenced
this pull request
Jul 11, 2026
* Add missing instruction offsets * Revert of MinecraftForge/ForgeFlower/pull/105 Revert of d88f743 Fixes #596 * temp undo * Fix dec file issues * Update kotlin dec file (cherry picked from commit 5c3607387f342e042e2232f62999e133f16ae2c9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable's are detected by using the start and and type but in the finally block the store instruction for the exception was removed but not the offset for that instruction causing the instruction offset to be different than expected
1.18 Pre Release 1 diff: