[Request] NBSP Localization Fix

[Elvarion]

Using Swedish (And French, possibly other languages?) as localization for you OS will cause mods that use numbers above 1000 to be faulty displayed. Instead of a space or a comma it will display the Non-breaking space "NBSP".

Example of NBSP

And how it should look (Well look on English(UK) localization.)
I do not really care if its a space or a comma that is being displayed.
As long as the NBSP is not there i am happy

EnderIO made a workaround when they fixed it for the French localization. This fixed it for Swedish also. After contacting TinkersConstruct they also fixed it for their mod. But there is still mods out there that has this issue.

Perhaps we could get a fix for this in Forge so mods do not have to create workarounds for this?

---

Minecraft themselves will most likely not fix this since its not related to Vanilla and really only happens when playing with mods installed.
https://bugs.mojang.com/browse/MC-2595

Talking to EnderIO about the NBSP
Code

Talking to TinkersConstruct
Code

[bs2609]

Any relation to MC-88484?

[mezz]

It looks like there are two issues here:

1. NBSP character should just look like a space. The character sheet in the default resource pack is incorrect.
2. Minecraft uses the ROOT locale for number formatting instead of the language set in the game

The proper solution for the first issue is fixing the actual font asset or adding a resource pack that changes the NBSP to a blank space. You can take a look in the minecraft jar at assets/minecraft/textures/font/unicode_page_00.png which contains the NBSP character. Forge is not in a good position to change this, Mojang is though.
It may be possible for Forge to re-route all lookups for the NBSP character to the regular space character, that may be the hacky solution to this issue until Mojang fixes it.

The second issue requires changing all formatting functions to be called with the correct Locale. While we could just do a single call to Locale.setDefault instead, there would certainly be unintended consequences. There are over 100 calls to String.format in vanilla Minecraft without specifying the locale, so this is a big change for a small gain (sorry). This part of the solution must come from Mojang.
For mods, they can properly fix their string formatting by calling String.format with a locale.

[Elvarion]

Thanks for the reply mezz and shedding some light on this matter

The proper solution for the first issue is fixing the actual font asset or adding a resource pack that changes the NBSP to a blank space.

Been there, done that. Sure it "does" solve it, however it does look somewhat strange since making the NBSP just blank will create a huge gap between the numbers.

As to what it should look like

There are over 100 calls to String.format in vanilla Minecraft without specifying the locale, so this is a big change for a small gain (sorry).

Dont be sorry 😄 , I have been living with this since mods came out pretty much. Came back to Minecraft a while ago and noticed that nearly all the NBSP was gone from EnderIO. So checked with other mod devs and asked if they could fix theirs also. So I thought that maybe Forge could apply a fix for this if it was a easy thing to do, turns out it wasn't. But it never hurts to ask!

Ill just go bug Mojang and mod devs to fix their code 😃

[mezz]

I will work on the NBSP issue since Mojang closed https://bugs.mojang.com/browse/MC-2595 as a "modding" issue.
I recommend opening a new bug that shows the problem using only vanilla and never mention modding. At worst, they will close it as a duplicate and re-open the original issue.

[mezz]

I'm not sure I can find a place where vanilla uses this separator, actually. It may be legitimate that they keep the issue closed.

[mezz]

Ok found a place, they use thousands separators for some of the game statistics, so you can report that.
Strangely it just uses a comma, and not the space for French. They force their number formatter there to use en_US. d'oh

[mezz]

Made a PR here #3522

[mezz]

I found the relevant Minecraft issue that may lead to the resolution of this problem.
I left a comment explaining how to reproduce the problem here, MC-33398.

[Elvarion]

All this code talk is not making much sense for me, But im very thankful for everything you guys are doing to help solve this 😃

[williewillus]

This is fixed in the next 1.11 snapshot so maybe we can backport that or just wait for it?