Replace non-functional StructureSpawnListGatherEvent with StructureModifiers#8717
Merged
LexManos merged 8 commits intoMinecraftForge:1.19.xfrom Jun 14, 2022
Merged
Conversation
pupnewfster
added
Feature
pupnewfster
added
the
Triage
marchermans
approved these changes
Jun 14, 2022
marchermans
added
Assigned
TelepathicGrunt
approved these changes
Jun 14, 2022
…es wrong between when we evaluated the ternary and executed the body
Fix dataprovider test cleanup
…just structure modifier test to use it, and add back some lines to the build.gradle I had removed
pupnewfster
force-pushed
the
spawn_list_gather
branch
from
17597df to
ec0e127
Compare
This was referenced Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General concept of this PR is that it adds a way to modify structure settings similar to how BiomeModifiers work. Also patches
NaturalSpawner#mobsAtto redirect nether fortress' from reading a hardcoded list to reading the list from its overrides (which by default contains the same elements).One thing I am unsure about is if we may want to extract the
Phaseenum up a level and just rename it toModifierPhaserather than having duplicates but I held off on doing so at least for now as that would break biome modifiers slightly and I am unsure how worthwhile it is breaking that system so soon after it was added.