Skip to content

feat: bind shared credentials to agent capabilities - #230

Merged
MiniMax-AI-Dev merged 15 commits into
feature/mcp-directory-oauth-foundationfrom
feature/mcp-capability-credential-binding
Jul 30, 2026
Merged

feat: bind shared credentials to agent capabilities#230
MiniMax-AI-Dev merged 15 commits into
feature/mcp-directory-oauth-foundationfrom
feature/mcp-capability-credential-binding

Conversation

@kapelame

@kapelame kapelame commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Let users select and persist an existing Workspace shared credential while enabling a Capability on an Agent. This completes the hosted OAuth connector flow introduced by #229 without adding a credential-binding table.

Scope

  • Store capability-level credential_bindings in the existing agent_capabilities.configuration JSON.
  • Default OAuth directory connectors to the shared Secret matching their catalog_id.
  • Share one frontend credential binding picker between Agent configuration and the existing credential check panel.
  • Centralize Go credential binding types, strict API parsing, lenient runtime parsing, and shared Secret validation.
  • Validate bindings during Capability enable, Agent create/edit, Capability version upgrade, and Public visibility changes.
  • Resolve capability bindings through the existing Agent runtime credential injection path.
  • Reject upgrades when the target Capability Version introduces unsatisfied credential requirements.
  • Reject Public visibility when any enabled Capability still relies on a personal credential.

Reuse and boundaries

Verification

  • make openapi
  • make check
  • Credential binding parser and shared Secret validation tests
  • Agent create/edit and Capability enable regression tests
  • Capability upgrade credential regression test
  • Public visibility capability-binding regression test
  • Runtime Secret resolution tests
  • Frontend typecheck and shared picker integration
  • git diff --check

Dependency

kapelame added 6 commits July 29, 2026 17:08
…p-capability-credential-binding

# Conflicts:
#	catalog/mcp/catalog.json
#	catalog/mcp/catalog.schema.json
#	server/internal/api/mcpdirectory/handler.go
#	server/internal/api/mcpdirectory/handler_test.go
#	server/internal/mcpcatalog/catalog_test.go
#	server/internal/mcpcatalog/types.go
#	server/internal/mcpcatalog/validate.go
#	server/internal/store/oauth_secret_test.go
#	server/migrations/000010_mcp_oauth_credential_kind.sql
@MiniMax-AI-Dev
MiniMax-AI-Dev merged commit 078b483 into feature/mcp-directory-oauth-foundation Jul 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants