fix: Improve file walker indexing speed#105
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
walk_fileswas encoding extension filters as !*.ext negation patterns in GitIgnoreSpec, causing 64k+ regex match_file calls per repo walk instead of a simple frozenset lookup. Fixed by moving extension filtering back to item.suffix.lower() in extensions_set in _walk, leaving only directory patterns in the spec.This also restores correct handling of explicit file inclusions: a file negated via a pattern with a file extension suffix (e.g. !special.kjs, !.yaml) now bypasses the extension filter as intended, while directory patterns (!vendor/) and suffix-less globs (!.github/) do not.