feat: turn Index to package#12
Merged
Merged
Conversation
Pringled
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large PR that makes the indexing object stateless. Instead of creating a
SembleIndexwith some of its essential attributes set toNone, the index creation is completely fronted: aSembleIndexalways has a model and is always indexed.The indexing loop was practically stateless, so I moved all functions that were part of
SembleIndexto separate files. Those files are now under a separate module calledindex.I fixed a bug: file_walker did not ignore ignored paths.
I also clarified the usage of
FILE_TYPES:index_by_defaultjust meant that the extension was a code file. So I made this explicit: every filetype now has aFileTypeTypewhich denotes that the file contains. In the future, we can expand this set and expose it, so an agent can do stuff like:For now, I left the API of the resolve_extensions file intact.