fix: disallow relative paths in user-supplied cache dir#182
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Confidence Score: 4/5Safe to merge; the change is narrow and correct, with the only open question being test completeness around the emitted warning. The implementation is straightforward and handles all cases (unset env var, relative path, absolute path) correctly. The sole observation is that the new test does not assert the tests/test_cache.py — the new test for the relative-path guard omits an assertion on the warning log. Reviews (1): Last reviewed commit: "fix: disallow relative paths in user-sup..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disallows relative paths as part of the user-supplied cache dir strategy. If the user supplies a relative path, we revert to the default index, and show a warning.