feat: Add zcode support#218
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Confidence Score: 5/5This looks safe to merge after a small compatibility cleanup.
src/semble/installer/config.py Reviews (1): Last reviewed commit: "Cleanup" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| """Add or update `section_key.member_key = value` in a JSON5 config file, preserving comments and formatting.""" | ||
| existed = path.exists() | ||
| text = path.read_text(encoding="utf-8") if existed else "" | ||
| section_path = section_key.split(".") |
There was a problem hiding this comment.
When an existing JSON config contains a literal top-level key like "mcp.servers", this split makes merge_json_member look for mcp then servers instead of updating that member. The install then writes a second nested mcp.servers tree and leaves the original entry behind, so callers using literal dotted section names can get duplicate or stale MCP config.
stephantul
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for zcode. ZCode nests its MCP servers two levels deep (
mcp.servers) instead of flat top-level key like every other supported agent, somerge_json_member/remove_json_memberare generalized to accept a dot-separated section key and create missing intermediate objects on demand. Closes #217.