Feature/iif upgrade#14
Open
EAlexJ wants to merge 2 commits into
Open
Conversation
This is implemented for interp backend only
eyck
reviewed
Jun 3, 2026
| * | ||
| * @return core id | ||
| */ | ||
| virtual unsigned get_core_id() = 0; |
Contributor
There was a problem hiding this comment.
Wouldn't it make sense to have a default implementation returning 0?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Has some overlap with #13
Also adds get_core_id to the iif, this means dbt-rise-riscv will have to be upgraded in tandem in projects that use this