[FEAT]: Improve API remove documents /v1/system/remove-documents

[byzheng]

How are you running AnythingLLM?

AnythingLLM desktop app

What happened?

This is a following question (#1894). But I think it would be better to separately report.

After adding a new document with document/raw-text API, I want to remove this document with /system/remove-documents. There is some trouble to remove this document with names property in the DELETE request.

If id is used (i.e. 99502983-20fa-4cd1-bef5-e17cd0c56dae, I get an success response, but the document is still in the workspace.

Then I test the name retrieved from document api, i.e. raw-title-99502983-20fa-4cd1-bef5-e17cd0c56dae.json or ``

Are there known steps to reproduce?

No response

[timothycarambat]

You will always get a 200 unless there is a server error:
ref:

anything-llm/server/endpoints/system.js

Line 323 in 7b42a67

response.sendStatus(200).end();

However, the correct path to put in is the folder + filename - the 200 will return even if the document is not found or deleted to prevent people trying to traverse or remove all documents.

In this case the document should be something like custom-documents/raw-title-99502983-20fa-4cd1-bef5-e17cd0c56dae - however this kind of nature for deletion should be revisited to be more trivial since it is indeed quite unclear.