Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a lot of file splits, source structure changes and much more tests.
Moreover a couple of found bugs were fixed (and opinionated changes made):
config.go: KnownFields(true) — unknown/misspelled config keys now hard-error instead of silent ignore.TruncateLength < 0clamps to 0.execute.go: absolute--values/readme/schema-filepaths now honored (previously always joined under chartDir). Empty path flag (--values-file "") falls back to built-indefault, not config value — deliberate, documented.
kube/resolve.go: GVK index augmented fromx-kubernetes-group-version-kind; a formerly-unique match can now be flagged ambiguous. Deduped and tested.kube/kube.go:KubeSchemaVersion→SchemaVersion(package-internal rename).