Skip to content

GEOPY-3011: Review logging and metric for tile size in Megabytes vs Mebibytes - #457

Merged
domfournier merged 2 commits into
developfrom
GEOPY-3011
Jul 31, 2026
Merged

GEOPY-3011: Review logging and metric for tile size in Megabytes vs Mebibytes#457
domfournier merged 2 commits into
developfrom
GEOPY-3011

Conversation

@domfournier

@domfournier domfournier commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

GEOPY-3011 - Review logging and metric for tile size in Megabytes vs Mebibytes

Copilot AI review requested due to automatic review settings July 29, 2026 18:52
@github-actions github-actions Bot changed the title GEOPY-3011 GEOPY-3011: Review logging and metric for tile size in Megabytes vs Mebibytes Jul 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates output reporting and regression expectations, primarily to standardize how tile-size estimates are labeled/logged (bytes vs bits, SI vs IEC), and to align test baselines with current inversion behavior.

Changes:

  • Standardized numeric formatting/targets in test utilities and updated multiple target_run regression constants.
  • Updated tile size estimate labels from Gb to GB in logs/plots (unit presentation).
  • Changed topography active-cell masking to use cell-bottom referencing for certain inversion types, updating downstream regression expectations.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/utils/targets.py Formats printed inversion metrics in scientific notation for more consistent output.
tests/run_tests/driver_mt_test.py Updates regression target_run values to match current results.
tests/run_tests/driver_joint_cross_gradient_test.py Updates regression target_run and expected scaling/multiplier arrays.
tests/run_tests/driver_ip_test.py Updates regression target_run values.
tests/run_tests/driver_ip_2d_test.py Updates regression target_run values.
tests/run_tests/driver_dc_test.py Updates regression target_run values.
tests/run_tests/driver_dc_2d_test.py Updates regression target_run values.
tests/run_tests/driver_dc_2d_rotated_gradients_test.py Updates regression target_run values and relaxes tolerance for the check.
simpeg_drivers/utils/tile_estimate.py Renames displayed units from Gb to GB in log output and plot labeling.
simpeg_drivers/components/topography.py Alters active-cell selection behavior by switching the topography reference point for some inversion types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread simpeg_drivers/utils/tile_estimate.py
Comment thread simpeg_drivers/components/topography.py
Comment thread simpeg_drivers/utils/tile_estimate.py
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (23da748) to head (092c952).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #457   +/-   ##
========================================
  Coverage    90.29%   90.29%           
========================================
  Files          113      113           
  Lines         7020     7020           
  Branches       865      865           
========================================
  Hits          6339     6339           
  Misses         465      465           
  Partials       216      216           
Files with missing lines Coverage Δ
simpeg_drivers/utils/tile_estimate.py 87.68% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmcga gmcga left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@domfournier
domfournier merged commit 004c621 into develop Jul 31, 2026
18 checks passed
@domfournier
domfournier deleted the GEOPY-3011 branch July 31, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants