feat(mobile): add the settings shell - #535
Merged
Miracle656 merged 4 commits intoJul 28, 2026
Merged
Conversation
The mobile shell rendered everything in the system font. Load the four brand typefaces at startup with useFonts and hold render behind the splash screen so the UI never flashes a system font. - theme/typography.ts: font assets + role→family map + role text styles, mirroring the web wallet (Lora 600 italic headings, Anton accent caps at 0.08em, Inter body, Inconsolata addresses/hashes). - app/_layout.tsx: preventAutoHideAsync + useFonts(fontAssets); render held until fonts resolve, then hideAsync. - app/fonts.tsx: a /fonts specimen screen rendering all four roles. Closes Miracle656#432
Build the reusable components every screen composes from, as native ports of the web wallet's core CSS classes so feature screens don't re-implement layout chrome. - theme/colors.ts: native palette mirroring globals.css :root vars. - components/ui/Screen.tsx (.wallet-shell shell + safe area), Card.tsx (.card/.card-md), Button.tsx (.btn-gold/.btn-ghost gold variants), AddressChip.tsx (.address-chip, Inconsolata + tap-to-copy via expo-clipboard), Highlight.tsx (.hl gold underlay). - app/_layout.tsx: wrap in SafeAreaProvider (required by Screen). - app/ui.tsx: /ui gallery rendering every primitive for side-by-side check. Closes Miracle656#433
Establish the settings screen structure, ported from the web wallet's settings page: configuration grouped into Security / Preferences / General sections of navigable rows, plus a wallet-address card. Selecting a row opens that section's detail (in-page navigation mirroring the web page's section state); later settings issues fill each with real controls. Composes the shared UI primitives (Screen, Card, AddressChip). Closes Miracle656#488
|
@Ipramking is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Ipramking Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…shell # Conflicts: # frontend/mobile/app/_layout.tsx # frontend/mobile/package-lock.json # frontend/mobile/package.json
Owner
|
Thanks @Ipramking — settings shell built on the shared primitives from #433 and typography from #432, with a wallet card using the tap-to-copy AddressChip. Rounds out the Ipramking stack nicely. Closes #488. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Establishes the settings screen structure at
app/(tabs)/settings.tsx, ported from the web wallet's settings page (frontend/wallet/app/settings/page.tsx). This is the shell that later settings issues fill with real controls.Screen
WALLETlabel over anAddressChip(reuses the 5. Shared UI primitives #433 primitive, tap-to-copy).sectionstate. (Detail screens are placeholders — real controls arrive in the follow-up settings issues.) This avoids linking to routes that don't exist yet undertypedRoutes.Composes the shared primitives
Screen,Card,AddressChip.Acceptance
✅ Three grouped sections render; tapping any row navigates to its section detail and back.
Stacked on #532 → #531
Builds on the shared primitives (#433, PR #532) and typography (#432, PR #531). Until those merge the diff includes their commits — review the
feat(mobile): add the settings shellcommit for this issue. I'll rebase as they land.Verification (local — no mobile CI job)
npm run typecheck✅ ·eslint app/(tabs)/settings.tsx✅Closes #488