Skip to content

feat(l10n): add Korean localization - #6506

Merged
crossle merged 4 commits into
masterfrom
feat/complete-traditional-and-korean-translations
Aug 4, 2026
Merged

feat(l10n): add Korean localization#6506
crossle merged 4 commits into
masterfrom
feat/complete-traditional-and-korean-translations

Conversation

@SeniorZhai

Copy link
Copy Markdown
Member

No description provided.

@SeniorZhai SeniorZhai added the testing Now testing, but you can review label Jul 15, 2026
@SeniorZhai
SeniorZhai force-pushed the feat/complete-traditional-and-korean-translations branch from fdebe65 to b8d9fd6 Compare July 15, 2026 07:34
Copilot AI review requested due to automatic review settings July 22, 2026 10:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables Korean localization across app packaging, locale selection, and identity verification, while expanding several existing translation catalogs.

Changes:

  • Registers and packages the Korean locale.
  • Adds Korean to legacy and Compose language selectors.
  • Adds or completes localized strings and arrays for supported languages.

Reviewed changes

Copilot reviewed 18 out of 20 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
app/build.gradle.kts Packages Korean resources.
app/src/main/java/one/mixin/android/Constants.kt Defines the Korean locale.
app/src/main/java/one/mixin/android/ui/setting/AppearanceFragment.kt Adds Korean selection support.
app/src/main/java/one/mixin/android/ui/setting/ui/page/AppearancePage.kt Exposes Spanish and Korean options.
app/src/main/java/one/mixin/android/ui/wallet/IdentityFragment.kt Passes Korean locale to identity verification.
app/src/main/res/xml/locales_config.xml Registers Korean as supported.
app/src/main/res/values/arrays.xml Adds the Korean language name.
app/src/main/res/values-ko/arrays.xml Adds Korean array resources.
app/src/main/res/values-zh-rTW/strings.xml Expands Traditional Chinese strings.
app/src/main/res/values-zh-rTW/arrays.xml Adds Traditional Chinese arrays.
app/src/main/res/values-zh-rCN/arrays.xml Adds localized database labels.
app/src/main/res/values-ru/strings.xml Adds Russian login strings.
app/src/main/res/values-ru/arrays.xml Adds Russian arrays and plurals.
app/src/main/res/values-ms/arrays.xml Completes Malay arrays.
app/src/main/res/values-ja/strings.xml Fixes and expands Japanese strings.
app/src/main/res/values-ja/arrays.xml Completes Japanese arrays.
app/src/main/res/values-in/arrays.xml Completes Indonesian arrays.
app/src/main/res/values-es/strings.xml Adds Spanish login strings.
app/src/main/res/values-es/arrays.xml Adds Spanish arrays and plurals.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/build.gradle.kts
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Copilot AI review requested due to automatic review settings July 24, 2026 04:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 20 changed files in this pull request and generated 1 comment.

Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Copilot AI review requested due to automatic review settings July 24, 2026 04:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 5 comments.

Comment thread app/src/main/res/values-ru/arrays.xml
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Copilot AI review requested due to automatic review settings July 24, 2026 04:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 25 changed files in this pull request and generated 2 comments.

Comment thread app/src/main/res/values-ko/strings.xml Outdated
Comment thread app/src/main/res/values-ko/strings.xml Outdated
Copilot AI review requested due to automatic review settings July 24, 2026 04:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 25 changed files in this pull request and generated 3 comments.

Comment thread app/src/main/res/values-ko/strings.xml Outdated
Comment thread app/src/main/res/values-ko/strings.xml Outdated
Comment thread app/src/main/res/values-ko/strings.xml Outdated
Copilot AI review requested due to automatic review settings July 24, 2026 04:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 25 changed files in this pull request and generated 6 comments.

Comment thread app/src/main/res/values/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml Outdated
Copilot AI review requested due to automatic review settings July 24, 2026 04:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 25 changed files in this pull request and generated 2 comments.

Comment thread app/src/main/res/values-ko/strings.xml Outdated
Copilot AI review requested due to automatic review settings July 24, 2026 05:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 25 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

app/src/androidTest/java/one/mixin/android/StringResourceFormatInstrumentedTest.kt:23

  • The new format validation only enumerates R.string, so it never checks plural resources. This PR adds and changes localized <plurals> entries; a mismatched placeholder in any quantity would still escape this test and could fail when formatted via getQuantityString. Please enumerate R.plurals and validate each supported quantity as well.
        val stringIds = stringResourceIds()

Copilot AI review requested due to automatic review settings July 24, 2026 05:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 34 changed files in this pull request and generated 2 comments.

Comment thread app/src/main/res/values-ko/strings.xml Outdated
Comment on lines +155 to +156
R.string.member_title_mixin_safe to "Mixin Safe",
R.string.member_title_mixin_star to "Mixin Star",
Copilot AI review requested due to automatic review settings July 24, 2026 05:30
@SeniorZhai
SeniorZhai force-pushed the feat/complete-traditional-and-korean-translations branch from 65e2e6f to bd94c7c Compare July 24, 2026 05:30
@SeniorZhai
SeniorZhai force-pushed the feat/complete-traditional-and-korean-translations branch from bd94c7c to a2bac40 Compare July 24, 2026 05:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 34 changed files in this pull request and generated 1 comment.

Comment on lines +211 to +212
AppearanceFragment.POS_Spanish,
AppearanceFragment.POS_KOREAN,
Copilot AI review requested due to automatic review settings July 24, 2026 05:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 34 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

app/src/androidTest/java/one/mixin/android/StringResourceFormatInstrumentedTest.kt:168

  • This canonical-name regression test omits Google_Pay and ID, so it currently passes even though the new Korean resources override both non-translatable labels. Include them in the map so the test enforces the same contract for these user-visible names.
                R.string.Toncoin to "TON",

Comment thread app/src/main/res/values-ko/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rTW/strings.xml
Copilot AI review requested due to automatic review settings July 28, 2026 05:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 34 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 28, 2026 05:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 34 changed files in this pull request and generated no new comments.

@SeniorZhai SeniorZhai removed the testing Now testing, but you can review label Jul 28, 2026
Copilot AI review requested due to automatic review settings July 28, 2026 06:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 34 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

app/src/androidTest/java/one/mixin/android/StringResourceFormatInstrumentedTest.kt:18

  • This validation is under src/androidTest, but the repository’s only CI workflow runs testGooglePlayDebugUnitTest and never runs instrumentation tests (.github/workflows/android.yml:37-38). As a result, malformed localized format strings will not fail pull requests. Move this to a Robolectric/unit test or add a managed-device/instrumentation test task to CI.
@RunWith(AndroidJUnit4::class)
class StringResourceFormatInstrumentedTest {

@crossle
crossle merged commit 1080471 into master Aug 4, 2026
2 checks passed
@crossle
crossle deleted the feat/complete-traditional-and-korean-translations branch August 4, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants