Skip to content

[feature] 지원서 목록 조회 응답에 createdAt 추가 - #1891

Merged
seongwon030 merged 2 commits into
develop/befrom
feature/application-forms-created-at-be
Aug 10, 2026
Merged

[feature] 지원서 목록 조회 응답에 createdAt 추가#1891
seongwon030 merged 2 commits into
develop/befrom
feature/application-forms-created-at-be

Conversation

@seongwon030

@seongwon030 seongwon030 commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

#1881 프론트엔드 작업에서 요청한 백엔드 연동 건입니다.

GET /api/club/application 응답의 forms[].forms[] 각 항목에 createdAt을 추가합니다.
프론트엔드 연도 상세 페이지의 최근 생성순 정렬 및 생성일 표시 기능이 이 필드를 필요로 합니다.

변경 사항

  • ClubApplicationFormsResultItem에 createdAt 필드 추가
  • ClubApplicationFormsRepositoryCustom의 aggregation 두 곳에 createdAt 반영
    • $project 단계
    • $group의 $push 문서 (여기가 빠지면 최종 응답에 실리지 않음)

참고

  • ClubApplicationForm 엔티티에는 이미 createdAt이 있고 @Builder.Default로 생성 시점에 항상 채워집니다.
  • 이 필드는 컬렉션 최초 생성 커밋(97051726)부터 존재해서 createdAt이 없는 레거시 문서는 없습니다. 따라서 $ifNull 폴백 없이 그대로 프로젝션했습니다.
  • 관리자 전용 /api/admin/club/{clubId}/application은 별도 경로(AdminClubApplicationFormResponse)를 사용하며 이번 범위에 포함하지 않았습니다.

Test plan

  • ./gradlew compileJava, ./gradlew compileTestJava 통과
  • ClubApplyAdminServiceTest.getClubApplicationFormsIncludesCreatedAt 통과 (CI 확인 필요)

통합 테스트를 추가했습니다. createdAt과 editedAt을 서로 다른 값으로 저장한 뒤 조회해서, 두 필드가 각각 올바르게 매핑되는지 검증합니다. $project나 $push 중 하나라도 누락되면 실패합니다.

@seongwon030 @claude
feat(club): 지원서 목록 조회 응답에 createdAt 추가
9d9b926 
프론트엔드에서 연도별 지원서 목록을 최근 생성순으로 정렬하려면
createdAt이 필요한데, 기존 aggregation 결과에는 editedAt만 포함되어 있었다.

ClubApplicationForm 엔티티에는 이미 createdAt이 존재하므로
aggregation의 $project와 $group의 $push 양쪽에 필드를 추가하고
응답 DTO에 노출한다.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MJcd3baP1SxJdS6Y1La4WG
@gemini-code-assist

gemini-code-assist Bot commented Aug 3, 2026

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@vercel

vercel Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
moadong Ready Ready Preview Aug 3, 2026 3:33pm

@coderabbitai

coderabbitai Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seongwon030, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 709415a5-0e22-4f9c-b9aa-27c76f1631b3

📥 Commits

Reviewing files that changed from the base of the PR and between 7b5b337 and 9715195.

📒 Files selected for processing (3)
  • backend/src/main/java/moadong/club/payload/dto/ClubApplicationFormsResultItem.java
  • backend/src/main/java/moadong/club/repository/ClubApplicationFormsRepositoryCustom.java
  • backend/src/test/java/moadong/club/service/ClubApplyAdminServiceTest.java

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1) 
Validation error: Invalid regex pattern for base branch. at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

275 tests   275 ✅  34s ⏱️
 48 suites    0 💤
 48 files      0 ❌

Results for commit 9715195.

♻️ This comment has been updated with latest results.

@seongwon030 @claude
fix(test): createdAt 검증 테스트가 레포지토리를 직접 호출하도록 수정
9715195 
테스트 픽스처가 User.clubId를 채우지 않아 CustomUserDetails.clubId가
null이 되고, 서비스 경유 조회가 항상 빈 결과를 반환해 테스트가 실패했다.

검증 대상은 aggregation이므로 clubId를 직접 넘겨 레포지토리를 호출한다.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MJcd3baP1SxJdS6Y1La4WG
@seongwon030
seongwon030 merged commit d871d24 into develop/be Aug 10, 2026
5 checks passed
@seongwon030
seongwon030 deleted the feature/application-forms-created-at-be branch August 10, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@seongwon030 seongwon030

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@seongwon030